| Message ID | 20210317145234.3171021-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] e1000e: Mark e1000e_pm_prepare() as __maybe_unused | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: davem@davemloft.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 4 this patch: 4 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | Link |
On 3/17/2021 16:52, 'w00385741 wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > The function e1000e_pm_prepare() may have no callers depending > on configuration, so it must be marked __maybe_unused to avoid > harmless warning: > > drivers/net/ethernet/intel/e1000e/netdev.c:6926:12: > warning: 'e1000e_pm_prepare' defined but not used [-Wunused-function] > 6926 | static int e1000e_pm_prepare(struct device *dev) > | ^~~~~~~~~~~~~~~~~ > > Fixes: ccf8b940e5fd ("e1000e: Leverage direct_complete to speed up s2ram") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Sasha Neftin <sasha.neftin@intel.com> > diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c > index f1c9debd9f3b..d2e4653536c5 100644 > --- a/drivers/net/ethernet/intel/e1000e/netdev.c > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > @@ -6923,7 +6923,7 @@ static int __e1000_resume(struct pci_dev *pdev) > return 0; > } > > -static int e1000e_pm_prepare(struct device *dev) > +static __maybe_unused int e1000e_pm_prepare(struct device *dev) > { > return pm_runtime_suspended(dev) && > pm_suspend_via_firmware(); > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan >
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index f1c9debd9f3b..d2e4653536c5 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -6923,7 +6923,7 @@ static int __e1000_resume(struct pci_dev *pdev) return 0; } -static int e1000e_pm_prepare(struct device *dev) +static __maybe_unused int e1000e_pm_prepare(struct device *dev) { return pm_runtime_suspended(dev) && pm_suspend_via_firmware();