| Message ID | 20210322093009.3677265-1-olteanv@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3de43dc98615b15516ec65591ebe28ceb7d8d921 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: dsa: mv88e6xxx: fix up kerneldoc some more | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 3 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, Mar 22, 2021 at 11:30:09AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > Commit 0b5294483c35 ("net: dsa: mv88e6xxx: scratch: Fixup kerneldoc") > has addressed some but not all kerneldoc warnings for the Global 2 > Scratch register accessors. Namely, we have some mismatches between > the function names in the kerneldoc and the ones in the actual code. > Let's adjust the comments so that they match the functions they're > sitting next to. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 22 Mar 2021 11:30:09 +0200 you wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > Commit 0b5294483c35 ("net: dsa: mv88e6xxx: scratch: Fixup kerneldoc") > has addressed some but not all kerneldoc warnings for the Global 2 > Scratch register accessors. Namely, we have some mismatches between > the function names in the kerneldoc and the ones in the actual code. > Let's adjust the comments so that they match the functions they're > sitting next to. > > [...] Here is the summary with links: - [net-next] net: dsa: mv88e6xxx: fix up kerneldoc some more https://git.kernel.org/netdev/net-next/c/3de43dc98615 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/dsa/mv88e6xxx/global2_scratch.c b/drivers/net/dsa/mv88e6xxx/global2_scratch.c index 7c2c67405322..eda710062933 100644 --- a/drivers/net/dsa/mv88e6xxx/global2_scratch.c +++ b/drivers/net/dsa/mv88e6xxx/global2_scratch.c @@ -42,7 +42,7 @@ static int mv88e6xxx_g2_scratch_write(struct mv88e6xxx_chip *chip, int reg, } /** - * mv88e6xxx_g2_scratch_gpio_get_bit - get a bit + * mv88e6xxx_g2_scratch_get_bit - get a bit * @chip: chip private data * @base_reg: base of scratch bits * @offset: index of bit within the register @@ -67,7 +67,7 @@ static int mv88e6xxx_g2_scratch_get_bit(struct mv88e6xxx_chip *chip, } /** - * mv88e6xxx_g2_scratch_gpio_set_bit - set (or clear) a bit + * mv88e6xxx_g2_scratch_set_bit - set (or clear) a bit * @chip: chip private data * @base_reg: base of scratch bits * @offset: index of bit within the register @@ -240,7 +240,7 @@ const struct mv88e6xxx_gpio_ops mv88e6352_gpio_ops = { }; /** - * mv88e6xxx_g2_gpio_set_smi - set gpio muxing for external smi + * mv88e6xxx_g2_scratch_gpio_set_smi - set gpio muxing for external smi * @chip: chip private data * @external: set mux for external smi, or free for gpio usage *