diff mbox series

[bpf-next] bpf: Fix a spelling typo in kernel/bpf/disasm.c

Message ID 20210325020511.5891-1-xukuohai@huawei.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series [bpf-next] bpf: Fix a spelling typo in kernel/bpf/disasm.c | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for bpf-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 8 maintainers not CCed: netdev@vger.kernel.org yhs@fb.com kpsingh@kernel.org daniel@iogearbox.net andrii@kernel.org kafai@fb.com john.fastabend@gmail.com songliubraving@fb.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/header_inline success Link

Commit Message

Xu Kuohai March 25, 2021, 2:05 a.m. UTC
The name string for BPF_XOR is "xor", not "or", fix it.

Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
---
 kernel/bpf/disasm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brendan Jackman March 25, 2021, 10:14 a.m. UTC | #1
[Sorry if you get this duplicated - I forgot to switch off HTML mode
the first time]

Oops, thanks.

On Thu, 25 Mar 2021 at 03:04, Xu Kuohai <xukuohai@huawei.com> wrote:
>
> The name string for BPF_XOR is "xor", not "or", fix it.
>
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>

Please add:
Fixes: 981f94c3e92146705b ("bpf: Add bitwise atomic instructions")

Except for that:
Acked-by: Brendan Jackman <jackmanb@google.com>

> ---
>  kernel/bpf/disasm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
> index 3acc7e0b6916..faa54d58972c 100644
> --- a/kernel/bpf/disasm.c
> +++ b/kernel/bpf/disasm.c
> @@ -84,7 +84,7 @@ static const char *const bpf_atomic_alu_string[16] = {
>         [BPF_ADD >> 4]  = "add",
>         [BPF_AND >> 4]  = "and",
>         [BPF_OR >> 4]  = "or",
> -       [BPF_XOR >> 4]  = "or",
> +       [BPF_XOR >> 4]  = "xor",
>  };
>
>  static const char *const bpf_ldst_string[] = {
> --
> 2.27.0
>
diff mbox series

Patch

diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
index 3acc7e0b6916..faa54d58972c 100644
--- a/kernel/bpf/disasm.c
+++ b/kernel/bpf/disasm.c
@@ -84,7 +84,7 @@  static const char *const bpf_atomic_alu_string[16] = {
 	[BPF_ADD >> 4]  = "add",
 	[BPF_AND >> 4]  = "and",
 	[BPF_OR >> 4]  = "or",
-	[BPF_XOR >> 4]  = "or",
+	[BPF_XOR >> 4]  = "xor",
 };
 
 static const char *const bpf_ldst_string[] = {