| Message ID | 20210401064637.993327-1-wanjiabing@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2daae89666ad253281bb3d6a027c00a702c02eff |
| Delegated to: | BPF |
| Headers | show |
| Series | linux/bpf-cgroup.h: Delete repeated struct declaration | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
> On Mar 31, 2021, at 11:46 PM, Wan Jiabing <wanjiabing@vivo.com> wrote: > > struct bpf_prog is declared twice. There is one declaration > which is independent on the MACRO at 18th line. > So the below one is not needed though. Remove the duplicate. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Acked-by: Song Liu <songliubraving@fb.com> > --- > include/linux/bpf-cgroup.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h > index c42e02b4d84b..57b4d4b980e7 100644 > --- a/include/linux/bpf-cgroup.h > +++ b/include/linux/bpf-cgroup.h > @@ -418,7 +418,6 @@ int cgroup_bpf_prog_query(const union bpf_attr *attr, > union bpf_attr __user *uattr); > #else > > -struct bpf_prog; > struct cgroup_bpf {}; > static inline int cgroup_bpf_inherit(struct cgroup *cgrp) { return 0; } > static inline void cgroup_bpf_offline(struct cgroup *cgrp) {} > -- > 2.25.1 >
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 1 Apr 2021 14:46:37 +0800 you wrote: > struct bpf_prog is declared twice. There is one declaration > which is independent on the MACRO at 18th line. > So the below one is not needed though. Remove the duplicate. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > include/linux/bpf-cgroup.h | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - linux/bpf-cgroup.h: Delete repeated struct declaration https://git.kernel.org/bpf/bpf-next/c/2daae89666ad You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h index c42e02b4d84b..57b4d4b980e7 100644 --- a/include/linux/bpf-cgroup.h +++ b/include/linux/bpf-cgroup.h @@ -418,7 +418,6 @@ int cgroup_bpf_prog_query(const union bpf_attr *attr, union bpf_attr __user *uattr); #else -struct bpf_prog; struct cgroup_bpf {}; static inline int cgroup_bpf_inherit(struct cgroup *cgrp) { return 0; } static inline void cgroup_bpf_offline(struct cgroup *cgrp) {}
struct bpf_prog is declared twice. There is one declaration which is independent on the MACRO at 18th line. So the below one is not needed though. Remove the duplicate. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- include/linux/bpf-cgroup.h | 1 - 1 file changed, 1 deletion(-)