| Message ID | 20210413104447.965-1-rohitm@chelsio.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] tls/chtls: fix kernel panic with tls_toe | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 2 blamed authors not CCed: daniel@iogearbox.net dirk.vandermerwe@netronome.com; 5 maintainers not CCed: ayush.sawal@chelsio.com daniel@iogearbox.net dirk.vandermerwe@netronome.com matthieu.baerts@tessares.net stefan@datenfreihafen.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 93 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
On Tue, 13 Apr 2021 16:14:47 +0530 Rohit Maheshwari wrote: > If tls_toe is supported by any device, tls_toe will be enabled > and tls context will be created for listen sockets. But the > connections established in stack issue context delete for every > connection close, this causes kernel panic. > As part of the fix, if tls_toe is supported, don't initialize > tcp_ulp_ops. Also make sure tls context is freed only for listen > sockets. Still nack. Kernel TLS does not work on listening sockets, so the bug is that the offload TOE TLS does. Offloaded and non-offload TLS should be the same from uAPI perspective.
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c index 19dc7dc054a2..d06850575096 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c @@ -1275,16 +1275,6 @@ static void mk_tid_release(struct sk_buff *skb, INIT_TP_WR_CPL(req, CPL_TID_RELEASE, tid); } -static int chtls_get_module(struct sock *sk) -{ - struct inet_connection_sock *icsk = inet_csk(sk); - - if (!try_module_get(icsk->icsk_ulp_ops->owner)) - return -1; - - return 0; -} - static void chtls_pass_accept_request(struct sock *sk, struct sk_buff *skb) { @@ -1401,8 +1391,6 @@ static void chtls_pass_accept_request(struct sock *sk, if (!newsk) goto reject; - if (chtls_get_module(newsk)) - goto reject; inet_csk_reqsk_queue_added(sk); reply_skb->sk = newsk; chtls_install_cpl_ops(newsk); diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c index 9098b3eed4da..f3d981ec6573 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c @@ -569,11 +569,8 @@ static int do_chtls_setsockopt(struct sock *sk, int optname, static int chtls_setsockopt(struct sock *sk, int level, int optname, sockptr_t optval, unsigned int optlen) { - struct tls_context *ctx = tls_get_ctx(sk); - if (level != SOL_TLS) - return ctx->sk_proto->setsockopt(sk, level, - optname, optval, optlen); + return -EOPNOTSUPP; return do_chtls_setsockopt(sk, optname, optval, optlen); } diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index 47b7c5334c34..e03eed5f882e 100644 --- a/net/tls/tls_main.c +++ b/net/tls/tls_main.c @@ -718,8 +718,12 @@ static int tls_init(struct sock *sk) tls_build_proto(sk); #ifdef CONFIG_TLS_TOE + /* if tls_toe is supported by a device, return failure + * for this TCP_ULP operation. TLS TOE will take over + * from here. + */ if (tls_toe_bypass(sk)) - return 0; + return -EOPNOTSUPP; #endif /* The TLS ulp is currently supported only for TCP sockets diff --git a/net/tls/tls_toe.c b/net/tls/tls_toe.c index 7e1330f19165..21616c2511a7 100644 --- a/net/tls/tls_toe.c +++ b/net/tls/tls_toe.c @@ -47,9 +47,13 @@ static void tls_toe_sk_destruct(struct sock *sk) struct tls_context *ctx = tls_get_ctx(sk); ctx->sk_destruct(sk); - /* Free ctx */ - rcu_assign_pointer(icsk->icsk_ulp_data, NULL); - tls_ctx_free(sk, ctx); + /* toe_tls ctx is created only for listen sockets, + * don't free it for any other socket type. + */ + if (sk->sk_state == TCP_LISTEN) { + rcu_assign_pointer(icsk->icsk_ulp_data, NULL); + tls_ctx_free(sk, ctx); + } } int tls_toe_bypass(struct sock *sk) @@ -61,15 +65,20 @@ int tls_toe_bypass(struct sock *sk) spin_lock_bh(&device_spinlock); list_for_each_entry(dev, &device_list, dev_list) { if (dev->feature && dev->feature(dev)) { - ctx = tls_ctx_create(sk); - if (!ctx) - goto out; + /* ESTABLISHED socket may also reach here, make + * sure new context is not created for that. + */ + if (sk->sk_state == TCP_CLOSE) { + ctx = tls_ctx_create(sk); + if (!ctx) + goto out; - ctx->sk_destruct = sk->sk_destruct; - sk->sk_destruct = tls_toe_sk_destruct; - ctx->rx_conf = TLS_HW_RECORD; - ctx->tx_conf = TLS_HW_RECORD; - update_sk_prot(sk, ctx); + ctx->sk_destruct = sk->sk_destruct; + sk->sk_destruct = tls_toe_sk_destruct; + ctx->rx_conf = TLS_HW_RECORD; + ctx->tx_conf = TLS_HW_RECORD; + update_sk_prot(sk, ctx); + } rc = 1; break; }
If tls_toe is supported by any device, tls_toe will be enabled and tls context will be created for listen sockets. But the connections established in stack issue context delete for every connection close, this causes kernel panic. As part of the fix, if tls_toe is supported, don't initialize tcp_ulp_ops. Also make sure tls context is freed only for listen sockets. Fixes: 95fa145479fb ("bpf: sockmap/tls, close can race with map free") Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com> Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com> --- .../chelsio/inline_crypto/chtls/chtls_cm.c | 12 ------- .../chelsio/inline_crypto/chtls/chtls_main.c | 5 +-- net/tls/tls_main.c | 6 +++- net/tls/tls_toe.c | 31 ++++++++++++------- 4 files changed, 26 insertions(+), 28 deletions(-)