| Message ID | 20210416104416.88997-1-sgarzare@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] vsock/vmci: log once the failed queue pair allocation | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 3 blamed authors not CCed: acking@vmware.com dtor@vmware.com georgezhang@vmware.com; 3 maintainers not CCed: acking@vmware.com dtor@vmware.com georgezhang@vmware.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Fri, Apr 16, 2021 at 12:06:18PM +0000, Jorgen Hansen wrote: > > >On 16 Apr 2021, at 12:44, Stefano Garzarella <sgarzare@redhat.com<mailto:sgarzare@redhat.com>> wrote: > >VMCI feature is not supported in conjunction with the vSphere Fault >Tolerance (FT) feature. > >VMware Tools can repeatedly try to create a vsock connection. If FT is >enabled the kernel logs is flooded with the following messages: > > qp_alloc_hypercall result = -20 > Could not attach to queue pair with -20 > >"qp_alloc_hypercall result = -20" was hidden by commit e8266c4c3307 >("VMCI: Stop log spew when qp allocation isn't possible"), but "Could >not attach to queue pair with -20" is still there flooding the log. > >Since the error message can be useful in some cases, print it only once. > >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Signed-off-by: Stefano Garzarella <sgarzare@redhat.com<mailto:sgarzare@redhat.com>> >--- >net/vmw_vsock/vmci_transport.c | 3 +-- >1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c >index 8b65323207db..1c9ecb18b8e6 100644 >--- a/net/vmw_vsock/vmci_transport.c >+++ b/net/vmw_vsock/vmci_transport.c >@@ -568,8 +568,7 @@ vmci_transport_queue_pair_alloc(struct vmci_qp **qpair, > peer, flags, VMCI_NO_PRIVILEGE_FLAGS); >out: >if (err < 0) { >- pr_err("Could not attach to queue pair with %d\n", >- err); >+ pr_err_once("Could not attach to queue pair with %d\n", err); >err = vmci_transport_error_to_vsock_error(err); >} > >— >2.30.2 > > >Thanks a lot for fixing this. You're welcome! > >Reviewed-by: Jorgen Hansen <jhansen@vmware.com<mailto:jhansen@vmware.com>> > Thanks for the review! Patchwork didn't like it, I think there was some problem with your email client putting `<mailto:...>` links. I think it had to be: Reviewed-by: Jorgen Hansen <jhansen@vmware.com> Thanks, Stefano
diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 8b65323207db..1c9ecb18b8e6 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -568,8 +568,7 @@ vmci_transport_queue_pair_alloc(struct vmci_qp **qpair, peer, flags, VMCI_NO_PRIVILEGE_FLAGS); out: if (err < 0) { - pr_err("Could not attach to queue pair with %d\n", - err); + pr_err_once("Could not attach to queue pair with %d\n", err); err = vmci_transport_error_to_vsock_error(err); }
VMCI feature is not supported in conjunction with the vSphere Fault Tolerance (FT) feature. VMware Tools can repeatedly try to create a vsock connection. If FT is enabled the kernel logs is flooded with the following messages: qp_alloc_hypercall result = -20 Could not attach to queue pair with -20 "qp_alloc_hypercall result = -20" was hidden by commit e8266c4c3307 ("VMCI: Stop log spew when qp allocation isn't possible"), but "Could not attach to queue pair with -20" is still there flooding the log. Since the error message can be useful in some cases, print it only once. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> --- net/vmw_vsock/vmci_transport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)