| Message ID | 20210420142821.22645-1-michael@walle.cc (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1b8caefaf4f063fdc43e4078384d38ce96147b35 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: enetc: automatically select IERB module | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 6 this patch: 6 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, Apr 20, 2021 at 04:28:21PM +0200, Michael Walle wrote: > Now that enetc supports flow control we have to make sure the settings in > the IERB are correct. Therefore, we actually depend on the enetc-ierb > module. Previously it was possible that this module was disabled while the > enetc was enabled. Fix it by automatically select the enetc-ierb module. > > Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block") > Signed-off-by: Michael Walle <michael@walle.cc> > --- Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 16:28:21 +0200 you wrote: > Now that enetc supports flow control we have to make sure the settings in > the IERB are correct. Therefore, we actually depend on the enetc-ierb > module. Previously it was possible that this module was disabled while the > enetc was enabled. Fix it by automatically select the enetc-ierb module. > > Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block") > Signed-off-by: Michael Walle <michael@walle.cc> > > [...] Here is the summary with links: - [net-next] net: enetc: automatically select IERB module https://git.kernel.org/netdev/net-next/c/1b8caefaf4f0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig b/drivers/net/ethernet/freescale/enetc/Kconfig index d88f60c2bb82..cdc0ff89388a 100644 --- a/drivers/net/ethernet/freescale/enetc/Kconfig +++ b/drivers/net/ethernet/freescale/enetc/Kconfig @@ -2,7 +2,7 @@ config FSL_ENETC tristate "ENETC PF driver" depends on PCI && PCI_MSI - depends on FSL_ENETC_IERB || FSL_ENETC_IERB=n + select FSL_ENETC_IERB select FSL_ENETC_MDIO select PHYLINK select PCS_LYNX
Now that enetc supports flow control we have to make sure the settings in the IERB are correct. Therefore, we actually depend on the enetc-ierb module. Previously it was possible that this module was disabled while the enetc was enabled. Fix it by automatically select the enetc-ierb module. Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endpoint Register Block") Signed-off-by: Michael Walle <michael@walle.cc> --- drivers/net/ethernet/freescale/enetc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)