| Message ID | 20210426160823.4501-1-i.bornyakov@metrotek.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 152fa81109a8766c45bfd4aad9e8f4005566648d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: phy: marvell-88x2222: enable autoneg by default | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 26 Apr 2021 19:08:23 +0300 you wrote: > There is no real need for disabling autonigotiation in config_init(). > Leave it enabled by default. > > Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru> > --- > drivers/net/phy/marvell-88x2222.c | 2 -- > 1 file changed, 2 deletions(-) Here is the summary with links: - [net-next] net: phy: marvell-88x2222: enable autoneg by default https://git.kernel.org/netdev/net-next/c/152fa81109a8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/phy/marvell-88x2222.c b/drivers/net/phy/marvell-88x2222.c index 9b9ac3ef735d..d8b31d4d2a73 100644 --- a/drivers/net/phy/marvell-88x2222.c +++ b/drivers/net/phy/marvell-88x2222.c @@ -473,8 +473,6 @@ static int mv2222_config_init(struct phy_device *phydev) if (phydev->interface != PHY_INTERFACE_MODE_XAUI) return -EINVAL; - phydev->autoneg = AUTONEG_DISABLE; - return 0; }
There is no real need for disabling autonigotiation in config_init(). Leave it enabled by default. Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru> --- drivers/net/phy/marvell-88x2222.c | 2 -- 1 file changed, 2 deletions(-)