| Message ID | 20210511161300.3zsn4ufutgwzvst2@ipetronik.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 33e6b1674f339c5d3be56ec9b4921d1ddd14327d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: lan78xx: advertise tx software timestamping support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | fail | Series targets non-next tree, but doesn't contain any Fixes tags |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 2 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: From:/Signed-off-by: email name mismatch: 'From: Markus Bloechl <markus.bloechl@ipetronik.com>' != 'Signed-off-by: Markus Blöchl <markus.bloechl@ipetronik.com>' |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 2 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 18 May 2021 11:54:11 +0200 you wrote: > lan78xx already calls skb_tx_timestamp() in its lan78xx_start_xmit(). > Override .get_ts_info to also advertise this capability > (SOF_TIMESTAMPING_TX_SOFTWARE) via ethtool. > > Signed-off-by: Markus Blöchl <markus.bloechl@ipetronik.com> > --- > > [...] Here is the summary with links: - [net] net: lan78xx: advertise tx software timestamping support https://git.kernel.org/netdev/net/c/33e6b1674f33 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 6acc5e904518..02bce40a67e5 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1645,6 +1645,7 @@ static const struct ethtool_ops lan78xx_ethtool_ops = { .get_strings = lan78xx_get_strings, .get_wol = lan78xx_get_wol, .set_wol = lan78xx_set_wol, + .get_ts_info = ethtool_op_get_ts_info, .get_eee = lan78xx_get_eee, .set_eee = lan78xx_set_eee, .get_pauseparam = lan78xx_get_pause,
lan78xx already calls skb_tx_timestamp() in its lan78xx_start_xmit(). Override .get_ts_info to also advertise this capability (SOF_TIMESTAMPING_TX_SOFTWARE) via ethtool. Signed-off-by: Markus Blöchl <markus.bloechl@ipetronik.com> --- Notes: The main motivation for this patch was that e.g. linuxptp refuses to start if the driver lacks support for the required timestamping features. I also recognized that many usb ethernet drivers which use the usbnet infrastructure do not override .get_ts_info accordingly, despite calling skb_tx_timestamp() indirectly in their .ndo_start_xmit handler via usbnet_start_xmit(). For most of them the .get_ts_info override from usbnet is lost when they override .ethtool_ops again. Should they all receive a similar patch? drivers/net/usb/lan78xx.c | 1 + 1 file changed, 1 insertion(+) base-commit: a6f8ee58a8e35f7e4380a5efce312e2a5bc27497