| Message ID | 20210511181132.25851-1-snelson@pensando.io (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bcbda3fc616272686208f9c4d5f6dccb65360bd8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v4,net] ionic: fix ptp support config breakage | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: 'dependancy' may be misspelled - perhaps 'dependency'? |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 5/11/21 11:11 AM, Shannon Nelson wrote: > When IONIC=y and PTP_1588_CLOCK=m were set in the .config file > the driver link failed with undefined references. > > We add the dependancy > depends on PTP_1588_CLOCK || !PTP_1588_CLOCK > to clear this up. > > If PTP_1588_CLOCK=m, the depends limits IONIC to =m (or disabled). > If PTP_1588_CLOCK is disabled, IONIC can be any of y/m/n. > > Fixes: 61db421da31b ("ionic: link in the new hw timestamp code") > Reported-by: kernel test robot <lkp@intel.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: Allen Hubbe <allenbh@pensando.io> > Signed-off-by: Shannon Nelson <snelson@pensando.io> Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > > v4 - Jakub's rewrite > v3 - put version notes below ---, added Allen's Cc > v2 - added Fixes tag > --- > drivers/net/ethernet/pensando/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig > index 5f8b0bb3af6e..202973a82712 100644 > --- a/drivers/net/ethernet/pensando/Kconfig > +++ b/drivers/net/ethernet/pensando/Kconfig > @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO > config IONIC > tristate "Pensando Ethernet IONIC Support" > depends on 64BIT && PCI > + depends on PTP_1588_CLOCK || !PTP_1588_CLOCK > select NET_DEVLINK > select DIMLIB > help >
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Tue, 11 May 2021 11:11:32 -0700 you wrote: > When IONIC=y and PTP_1588_CLOCK=m were set in the .config file > the driver link failed with undefined references. > > We add the dependancy > depends on PTP_1588_CLOCK || !PTP_1588_CLOCK > to clear this up. > > [...] Here is the summary with links: - [v4,net] ionic: fix ptp support config breakage https://git.kernel.org/bpf/bpf/c/bcbda3fc6162 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig index 5f8b0bb3af6e..202973a82712 100644 --- a/drivers/net/ethernet/pensando/Kconfig +++ b/drivers/net/ethernet/pensando/Kconfig @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO config IONIC tristate "Pensando Ethernet IONIC Support" depends on 64BIT && PCI + depends on PTP_1588_CLOCK || !PTP_1588_CLOCK select NET_DEVLINK select DIMLIB help
When IONIC=y and PTP_1588_CLOCK=m were set in the .config file the driver link failed with undefined references. We add the dependancy depends on PTP_1588_CLOCK || !PTP_1588_CLOCK to clear this up. If PTP_1588_CLOCK=m, the depends limits IONIC to =m (or disabled). If PTP_1588_CLOCK is disabled, IONIC can be any of y/m/n. Fixes: 61db421da31b ("ionic: link in the new hw timestamp code") Reported-by: kernel test robot <lkp@intel.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Allen Hubbe <allenbh@pensando.io> Signed-off-by: Shannon Nelson <snelson@pensando.io> --- v4 - Jakub's rewrite v3 - put version notes below ---, added Allen's Cc v2 - added Fixes tag --- drivers/net/ethernet/pensando/Kconfig | 1 + 1 file changed, 1 insertion(+)