| Message ID | 20210518091141.2316684-1-zhengyejian1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4ac9e23cf2ccdad99dbc57d7d1bf264d53d23057 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] cipso: correct comments of cipso_v4_cache_invalidate() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: davem@davemloft.net; 5 maintainers not CCed: dsahern@kernel.org yoshfuji@linux-ipv6.org linux-security-module@vger.kernel.org davem@davemloft.net kuba@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
On Tue, May 18, 2021 at 5:05 AM Zheng Yejian <zhengyejian1@huawei.com> wrote: > > Since cipso_v4_cache_invalidate() has no return value, so drop > related descriptions in its comments. > > Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine") > Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com> > --- > net/ipv4/cipso_ipv4.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks for catching this. Acked-by: Paul Moore <paul@paul-moore.com> > diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c > index bfaf327e9d12..d6e3a92841e3 100644 > --- a/net/ipv4/cipso_ipv4.c > +++ b/net/ipv4/cipso_ipv4.c > @@ -187,8 +187,7 @@ static int __init cipso_v4_cache_init(void) > * cipso_v4_cache_invalidate - Invalidates the current CIPSO cache > * > * Description: > - * Invalidates and frees any entries in the CIPSO cache. Returns zero on > - * success and negative values on failure. > + * Invalidates and frees any entries in the CIPSO cache. > * > */ > void cipso_v4_cache_invalidate(void) > -- > 2.17.1
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 18 May 2021 17:11:41 +0800 you wrote: > Since cipso_v4_cache_invalidate() has no return value, so drop > related descriptions in its comments. > > Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine") > Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com> > --- > net/ipv4/cipso_ipv4.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Here is the summary with links: - [net-next] cipso: correct comments of cipso_v4_cache_invalidate() https://git.kernel.org/netdev/net-next/c/4ac9e23cf2cc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c index bfaf327e9d12..d6e3a92841e3 100644 --- a/net/ipv4/cipso_ipv4.c +++ b/net/ipv4/cipso_ipv4.c @@ -187,8 +187,7 @@ static int __init cipso_v4_cache_init(void) * cipso_v4_cache_invalidate - Invalidates the current CIPSO cache * * Description: - * Invalidates and frees any entries in the CIPSO cache. Returns zero on - * success and negative values on failure. + * Invalidates and frees any entries in the CIPSO cache. * */ void cipso_v4_cache_invalidate(void)
Since cipso_v4_cache_invalidate() has no return value, so drop related descriptions in its comments. Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine") Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com> --- net/ipv4/cipso_ipv4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)