| Message ID | 20210519021038.25928-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c71b99640d2d350ee3146452c1057bd59cb2c5e0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ethtool: stats: Fix a copy-paste error | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
On Wed, 19 May 2021 10:10:38 +0800 YueHaibing wrote: > data->ctrl_stats should be memset with correct size. > > Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Jakub Kicinski <kuba@kernel.org>
On Wed, 19 May 2021 10:10:38 +0800 YueHaibing wrote: > data->ctrl_stats should be memset with correct size. > > Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Ah, FWIW this should had been targeting net.
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 19 May 2021 10:10:38 +0800 you wrote: > data->ctrl_stats should be memset with correct size. > > Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > net/ethtool/stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] ethtool: stats: Fix a copy-paste error https://git.kernel.org/netdev/net/c/c71b99640d2d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/ethtool/stats.c b/net/ethtool/stats.c index b7642dc96d50..ec07f5765e03 100644 --- a/net/ethtool/stats.c +++ b/net/ethtool/stats.c @@ -119,7 +119,7 @@ static int stats_prepare_data(const struct ethnl_req_info *req_base, */ memset(&data->phy_stats, 0xff, sizeof(data->phy_stats)); memset(&data->mac_stats, 0xff, sizeof(data->mac_stats)); - memset(&data->ctrl_stats, 0xff, sizeof(data->mac_stats)); + memset(&data->ctrl_stats, 0xff, sizeof(data->ctrl_stats)); memset(&data->rmon_stats, 0xff, sizeof(data->rmon_stats)); if (test_bit(ETHTOOL_STATS_ETH_PHY, req_info->stat_mask) &&
data->ctrl_stats should be memset with correct size. Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/ethtool/stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)