| Message ID | 20210531020110.2920255-1-zhengyongjun3@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] sctp: sm_statefuns: Fix spelling mistakes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: 'genereate' may be misspelled - perhaps 'generate'? |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Sun, May 30, 2021 at 9:48 PM Zheng Yongjun <zhengyongjun3@huawei.com> wrote: > > Fix some spelling mistakes in comments: > genereate ==> generate > correclty ==> correctly > boundries ==> boundaries > failes ==> fails I believe more mistakes below in this file could hitchhike this patch to get fixed. :-) isses -> issues assocition -> association signe -> sign assocaition -> association managemement-> management restransmissions->retransmission sideffect -> sideeffect bomming -> booming chukns-> chunks SHUDOWN -> SHUTDOWN violationg->violating explcitly-> explicitly CHunk-> Chunk Thanks. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > net/sctp/sm_statefuns.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c > index fd1e319eda00..68e7d14c3799 100644 > --- a/net/sctp/sm_statefuns.c > +++ b/net/sctp/sm_statefuns.c > @@ -608,7 +608,7 @@ enum sctp_disposition sctp_sf_do_5_1C_ack(struct net *net, > sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE, > SCTP_STATE(SCTP_STATE_COOKIE_ECHOED)); > > - /* SCTP-AUTH: genereate the assocition shared keys so that > + /* SCTP-AUTH: generate the assocition shared keys so that > * we can potentially signe the COOKIE-ECHO. > */ > sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_SHKEY, SCTP_NULL()); > @@ -838,7 +838,7 @@ enum sctp_disposition sctp_sf_do_5_1D_ce(struct net *net, > > /* Add all the state machine commands now since we've created > * everything. This way we don't introduce memory corruptions > - * during side-effect processing and correclty count established > + * during side-effect processing and correctly count established > * associations. > */ > sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc)); > @@ -2950,7 +2950,7 @@ enum sctp_disposition sctp_sf_do_9_2_reshutack( > commands); > > /* Since we are not going to really process this INIT, there > - * is no point in verifying chunk boundries. Just generate > + * is no point in verifying chunk boundaries. Just generate > * the SHUTDOWN ACK. > */ > reply = sctp_make_shutdown_ack(asoc, chunk); > @@ -3560,7 +3560,7 @@ enum sctp_disposition sctp_sf_do_9_2_final(struct net *net, > goto nomem_chunk; > > /* Do all the commands now (after allocation), so that we > - * have consistent state if memory allocation failes > + * have consistent state if memory allocation fails > */ > sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, SCTP_ULPEVENT(ev)); > > -- > 2.25.1 >
Thanks for your advice, I will fix it as you suggest and send patch v2 :) -----邮件原件----- 发件人: Xin Long [mailto:lucien.xin@gmail.com] 发送时间: 2021年6月1日 0:24 收件人: zhengyongjun <zhengyongjun3@huawei.com> 抄送: Vlad Yasevich <vyasevich@gmail.com>; Neil Horman <nhorman@tuxdriver.com>; Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>; davem <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; linux-sctp @ vger . kernel . org <linux-sctp@vger.kernel.org>; network dev <netdev@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org> 主题: Re: [PATCH net-next] sctp: sm_statefuns: Fix spelling mistakes On Sun, May 30, 2021 at 9:48 PM Zheng Yongjun <zhengyongjun3@huawei.com> wrote: > > Fix some spelling mistakes in comments: > genereate ==> generate > correclty ==> correctly > boundries ==> boundaries > failes ==> fails I believe more mistakes below in this file could hitchhike this patch to get fixed. :-) isses -> issues assocition -> association signe -> sign assocaition -> association managemement-> management restransmissions->retransmission sideffect -> sideeffect bomming -> booming chukns-> chunks SHUDOWN -> SHUTDOWN violationg->violating explcitly-> explicitly CHunk-> Chunk Thanks. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > net/sctp/sm_statefuns.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index > fd1e319eda00..68e7d14c3799 100644 > --- a/net/sctp/sm_statefuns.c > +++ b/net/sctp/sm_statefuns.c > @@ -608,7 +608,7 @@ enum sctp_disposition sctp_sf_do_5_1C_ack(struct net *net, > sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE, > SCTP_STATE(SCTP_STATE_COOKIE_ECHOED)); > > - /* SCTP-AUTH: genereate the assocition shared keys so that > + /* SCTP-AUTH: generate the assocition shared keys so that > * we can potentially signe the COOKIE-ECHO. > */ > sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_SHKEY, SCTP_NULL()); > @@ -838,7 +838,7 @@ enum sctp_disposition sctp_sf_do_5_1D_ce(struct > net *net, > > /* Add all the state machine commands now since we've created > * everything. This way we don't introduce memory corruptions > - * during side-effect processing and correclty count established > + * during side-effect processing and correctly count > + established > * associations. > */ > sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, > SCTP_ASOC(new_asoc)); @@ -2950,7 +2950,7 @@ enum sctp_disposition sctp_sf_do_9_2_reshutack( > commands); > > /* Since we are not going to really process this INIT, there > - * is no point in verifying chunk boundries. Just generate > + * is no point in verifying chunk boundaries. Just generate > * the SHUTDOWN ACK. > */ > reply = sctp_make_shutdown_ack(asoc, chunk); @@ -3560,7 > +3560,7 @@ enum sctp_disposition sctp_sf_do_9_2_final(struct net *net, > goto nomem_chunk; > > /* Do all the commands now (after allocation), so that we > - * have consistent state if memory allocation failes > + * have consistent state if memory allocation fails > */ > sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, > SCTP_ULPEVENT(ev)); > > -- > 2.25.1 >
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index fd1e319eda00..68e7d14c3799 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -608,7 +608,7 @@ enum sctp_disposition sctp_sf_do_5_1C_ack(struct net *net, sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE, SCTP_STATE(SCTP_STATE_COOKIE_ECHOED)); - /* SCTP-AUTH: genereate the assocition shared keys so that + /* SCTP-AUTH: generate the assocition shared keys so that * we can potentially signe the COOKIE-ECHO. */ sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_SHKEY, SCTP_NULL()); @@ -838,7 +838,7 @@ enum sctp_disposition sctp_sf_do_5_1D_ce(struct net *net, /* Add all the state machine commands now since we've created * everything. This way we don't introduce memory corruptions - * during side-effect processing and correclty count established + * during side-effect processing and correctly count established * associations. */ sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc)); @@ -2950,7 +2950,7 @@ enum sctp_disposition sctp_sf_do_9_2_reshutack( commands); /* Since we are not going to really process this INIT, there - * is no point in verifying chunk boundries. Just generate + * is no point in verifying chunk boundaries. Just generate * the SHUTDOWN ACK. */ reply = sctp_make_shutdown_ack(asoc, chunk); @@ -3560,7 +3560,7 @@ enum sctp_disposition sctp_sf_do_9_2_final(struct net *net, goto nomem_chunk; /* Do all the commands now (after allocation), so that we - * have consistent state if memory allocation failes + * have consistent state if memory allocation fails */ sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, SCTP_ULPEVENT(ev));
Fix some spelling mistakes in comments: genereate ==> generate correclty ==> correctly boundries ==> boundaries failes ==> fails Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- net/sctp/sm_statefuns.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)