| Message ID | 20210602122114.2082344-3-olteanv@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Report tc-taprio window drops in NXP ENETC driver | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | CHECK: Please use a blank line after function/struct/union/enum declarations |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | Link |
On Wed, 2 Jun 2021 15:21:14 +0300 Vladimir Oltean wrote: > From: Po Liu <Po.Liu@nxp.com> > > The enetc scheduler for IEEE 802.1Qbv has 2 options (depending on > PTGCR[TG_DROP_DISABLE]) when we attempt to send an oversized packet > which will never fit in its allotted time slot for its traffic class: > either block the entire port due to head-of-line blocking, or drop the the entire port or the entire queue? > packet and set a bit in the writeback format of the transmit buffer > descriptor, allowing other packets to be sent. > > We obviously choose the second option in the driver, but we do not > detect the drop condition, so from the perspective of the network stack, > the packet is sent and no error counter is incremented. > > This change checks the writeback of the TX BD when tc-taprio is enabled, > and increments a specific ethtool statistics counter and a generic > "tx_dropped" counter in ndo_get_stats64. Any chance we should also report that back to the qdisc to have a standard way of querying from user space? Qdisc offload supports stats in general, it shouldn't be an issue, and the stat seems generic enough, no?
On Wed, Jun 02, 2021 at 10:19:20AM -0700, Jakub Kicinski wrote: > On Wed, 2 Jun 2021 15:21:14 +0300 Vladimir Oltean wrote: > > From: Po Liu <Po.Liu@nxp.com> > > > > The enetc scheduler for IEEE 802.1Qbv has 2 options (depending on > > PTGCR[TG_DROP_DISABLE]) when we attempt to send an oversized packet > > which will never fit in its allotted time slot for its traffic class: > > either block the entire port due to head-of-line blocking, or drop the > > the entire port or the entire queue? I don't remember, I need to re-test. > > packet and set a bit in the writeback format of the transmit buffer > > descriptor, allowing other packets to be sent. > > > > We obviously choose the second option in the driver, but we do not > > detect the drop condition, so from the perspective of the network stack, > > the packet is sent and no error counter is incremented. > > > > This change checks the writeback of the TX BD when tc-taprio is enabled, > > and increments a specific ethtool statistics counter and a generic > > "tx_dropped" counter in ndo_get_stats64. > > Any chance we should also report that back to the qdisc to have > a standard way of querying from user space? Qdisc offload supports > stats in general, it shouldn't be an issue, and the stat seems generic > enough, no? You're thinking of something along the lines of tc_codel_xstats? How do you propose I pass this on to the taprio qdisc? Just call a function in enetc that is exported by net/sched/sch_taprio.c? If the skb is bound to a socket, I'm thinking it might be more useful to report a struct sock_extended_err similar to the SO_EE_TXTIME_MISSED stuff for tc-etf, what do you think?
On Wed, 2 Jun 2021 20:59:37 +0300 Vladimir Oltean wrote: > On Wed, Jun 02, 2021 at 10:19:20AM -0700, Jakub Kicinski wrote: > > On Wed, 2 Jun 2021 15:21:14 +0300 Vladimir Oltean wrote: > > > From: Po Liu <Po.Liu@nxp.com> > > > > > > The enetc scheduler for IEEE 802.1Qbv has 2 options (depending on > > > PTGCR[TG_DROP_DISABLE]) when we attempt to send an oversized packet > > > which will never fit in its allotted time slot for its traffic class: > > > either block the entire port due to head-of-line blocking, or drop the > > > > the entire port or the entire queue? > > I don't remember, I need to re-test. > > > > packet and set a bit in the writeback format of the transmit buffer > > > descriptor, allowing other packets to be sent. > > > > > > We obviously choose the second option in the driver, but we do not > > > detect the drop condition, so from the perspective of the network stack, > > > the packet is sent and no error counter is incremented. > > > > > > This change checks the writeback of the TX BD when tc-taprio is enabled, > > > and increments a specific ethtool statistics counter and a generic > > > "tx_dropped" counter in ndo_get_stats64. > > > > Any chance we should also report that back to the qdisc to have > > a standard way of querying from user space? Qdisc offload supports > > stats in general, it shouldn't be an issue, and the stat seems generic > > enough, no? > > You're thinking of something along the lines of tc_codel_xstats? > How do you propose I pass this on to the taprio qdisc? Just call a > function in enetc that is exported by net/sched/sch_taprio.c? Check out red_dump_offload_stats()/TC_RED_STATS, this is the usual way of handling stats offload in TC. > If the skb is bound to a socket, I'm thinking it might be more useful to > report a struct sock_extended_err similar to the SO_EE_TXTIME_MISSED > stuff for tc-etf, what do you think? That's an interesting idea as well, dunno enough about the practical uses to be able to tell if applications care about per-socket state, per-interface state, or both.
diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index 3ca93adb9662..3f1cb921571a 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -170,7 +170,8 @@ static int enetc_map_tx_buffs(struct enetc_bdr *tx_ring, struct sk_buff *skb) } tx_swbd->do_twostep_tstamp = do_twostep_tstamp; - tx_swbd->check_wb = tx_swbd->do_twostep_tstamp; + tx_swbd->qbv_en = !!(priv->active_offloads & ENETC_F_QBV); + tx_swbd->check_wb = tx_swbd->do_twostep_tstamp || tx_swbd->qbv_en; if (do_vlan || do_onestep_tstamp || do_twostep_tstamp) flags |= ENETC_TXBD_FLAGS_EX; @@ -525,9 +526,9 @@ static void enetc_recycle_xdp_tx_buff(struct enetc_bdr *tx_ring, static bool enetc_clean_tx_ring(struct enetc_bdr *tx_ring, int napi_budget) { + int tx_frm_cnt = 0, tx_byte_cnt = 0, tx_win_drop = 0; struct net_device *ndev = tx_ring->ndev; struct enetc_ndev_priv *priv = netdev_priv(ndev); - int tx_frm_cnt = 0, tx_byte_cnt = 0; struct enetc_tx_swbd *tx_swbd; int i, bds_to_clean; bool do_twostep_tstamp; @@ -557,6 +558,10 @@ static bool enetc_clean_tx_ring(struct enetc_bdr *tx_ring, int napi_budget) &tstamp); do_twostep_tstamp = true; } + + if (tx_swbd->qbv_en && + txbd->wb.status & ENETC_TXBD_STATS_WIN) + tx_win_drop++; } if (tx_swbd->is_xdp_tx) @@ -610,6 +615,7 @@ static bool enetc_clean_tx_ring(struct enetc_bdr *tx_ring, int napi_budget) tx_ring->next_to_clean = i; tx_ring->stats.packets += tx_frm_cnt; tx_ring->stats.bytes += tx_byte_cnt; + tx_ring->stats.win_drop += tx_win_drop; if (unlikely(tx_frm_cnt && netif_carrier_ok(ndev) && __netif_subqueue_stopped(ndev, tx_ring->index) && @@ -2271,6 +2277,7 @@ struct net_device_stats *enetc_get_stats(struct net_device *ndev) struct enetc_ndev_priv *priv = netdev_priv(ndev); struct net_device_stats *stats = &ndev->stats; unsigned long packets = 0, bytes = 0; + unsigned long tx_dropped = 0; int i; for (i = 0; i < priv->num_rx_rings; i++) { @@ -2286,10 +2293,12 @@ struct net_device_stats *enetc_get_stats(struct net_device *ndev) for (i = 0; i < priv->num_tx_rings; i++) { packets += priv->tx_ring[i]->stats.packets; bytes += priv->tx_ring[i]->stats.bytes; + tx_dropped += priv->tx_ring[i]->stats.win_drop; } stats->tx_packets = packets; stats->tx_bytes = bytes; + stats->tx_dropped = tx_dropped; return stats; } diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/ethernet/freescale/enetc/enetc.h index 08b283347d9c..2a5973aebc31 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.h +++ b/drivers/net/ethernet/freescale/enetc/enetc.h @@ -34,6 +34,7 @@ struct enetc_tx_swbd { u8 is_eof:1; u8 is_xdp_tx:1; u8 is_xdp_redirect:1; + u8 qbv_en:1; }; #define ENETC_RX_MAXFRM_SIZE ENETC_MAC_MAXFRM_SIZE @@ -70,6 +71,7 @@ struct enetc_ring_stats { unsigned int xdp_redirect_sg; unsigned int recycles; unsigned int recycle_failures; + unsigned int win_drop; }; struct enetc_xdp_data { diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c index ebccaf02411c..4d55e78fa353 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -204,6 +204,7 @@ static const char tx_ring_stats[][ETH_GSTRING_LEN] = { "Tx ring %2d frames", "Tx ring %2d XDP frames", "Tx ring %2d XDP drops", + "Tx window drop %2d frames", }; static int enetc_get_sset_count(struct net_device *ndev, int sset) @@ -279,6 +280,7 @@ static void enetc_get_ethtool_stats(struct net_device *ndev, data[o++] = priv->tx_ring[i]->stats.packets; data[o++] = priv->tx_ring[i]->stats.xdp_tx; data[o++] = priv->tx_ring[i]->stats.xdp_tx_drops; + data[o++] = priv->tx_ring[i]->stats.win_drop; } for (i = 0; i < priv->num_rx_rings; i++) { diff --git a/drivers/net/ethernet/freescale/enetc/enetc_hw.h b/drivers/net/ethernet/freescale/enetc/enetc_hw.h index 0f5f081a5baf..e7fa4fb85d0b 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_hw.h +++ b/drivers/net/ethernet/freescale/enetc/enetc_hw.h @@ -543,6 +543,7 @@ enum enetc_txbd_flags { ENETC_TXBD_FLAGS_EX = BIT(6), ENETC_TXBD_FLAGS_F = BIT(7) }; +#define ENETC_TXBD_STATS_WIN BIT(7) #define ENETC_TXBD_TXSTART_MASK GENMASK(24, 0) #define ENETC_TXBD_FLAGS_OFFSET 24