| Message ID | 20210603095030.2920-1-zhangkaiheb@126.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ipv6: parameter p.name is empty | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Le 03/06/2021 à 11:50, zhang kai a écrit : > so do not check it. > > Signed-off-by: zhang kai <zhangkaiheb@126.com> > --- > net/ipv6/addrconf.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index b0ef65eb9..4c6b3fc7e 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, > if (err) > return err; > > - dev = __dev_get_by_name(net, p.name); > - if (!dev) > - return -ENOBUFS; > return dev_open(dev, NULL); > } > > This bug seems to exist since the beginning of the SIT driver (24 years!): https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a Search addrconf_set_dstaddr() Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
On 6/3/21 7:33 AM, Nicolas Dichtel wrote: > Le 03/06/2021 à 11:50, zhang kai a écrit : >> so do not check it. >> >> Signed-off-by: zhang kai <zhangkaiheb@126.com> >> --- >> net/ipv6/addrconf.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >> index b0ef65eb9..4c6b3fc7e 100644 >> --- a/net/ipv6/addrconf.c >> +++ b/net/ipv6/addrconf.c >> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, >> if (err) >> return err; >> >> - dev = __dev_get_by_name(net, p.name); >> - if (!dev) >> - return -ENOBUFS; >> return dev_open(dev, NULL); >> } >> >> > This bug seems to exist since the beginning of the SIT driver (24 years!): > https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a > Search addrconf_set_dstaddr() > > Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > A patch was sent yesterday, "sit: set name of device back to struct parms", to set the name field in params.
Le 03/06/2021 à 17:15, David Ahern a écrit : > On 6/3/21 7:33 AM, Nicolas Dichtel wrote: >> Le 03/06/2021 à 11:50, zhang kai a écrit : >>> so do not check it. >>> >>> Signed-off-by: zhang kai <zhangkaiheb@126.com> >>> --- >>> net/ipv6/addrconf.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >>> index b0ef65eb9..4c6b3fc7e 100644 >>> --- a/net/ipv6/addrconf.c >>> +++ b/net/ipv6/addrconf.c >>> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, >>> if (err) >>> return err; >>> >>> - dev = __dev_get_by_name(net, p.name); >>> - if (!dev) >>> - return -ENOBUFS; >>> return dev_open(dev, NULL); >>> } >>> >>> >> This bug seems to exist since the beginning of the SIT driver (24 years!): >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a >> Search addrconf_set_dstaddr() >> >> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> >> > > A patch was sent yesterday, "sit: set name of device back to struct > parms", to set the name field in params. > Oh yes, it was in my spam folder ...
On 6/3/21 10:29 AM, Nicolas Dichtel wrote: > Le 03/06/2021 à 17:15, David Ahern a écrit : >> On 6/3/21 7:33 AM, Nicolas Dichtel wrote: >>> Le 03/06/2021 à 11:50, zhang kai a écrit : >>>> so do not check it. >>>> >>>> Signed-off-by: zhang kai <zhangkaiheb@126.com> >>>> --- >>>> net/ipv6/addrconf.c | 3 --- >>>> 1 file changed, 3 deletions(-) >>>> >>>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >>>> index b0ef65eb9..4c6b3fc7e 100644 >>>> --- a/net/ipv6/addrconf.c >>>> +++ b/net/ipv6/addrconf.c >>>> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, >>>> if (err) >>>> return err; >>>> >>>> - dev = __dev_get_by_name(net, p.name); >>>> - if (!dev) >>>> - return -ENOBUFS; >>>> return dev_open(dev, NULL); >>>> } >>>> >>>> >>> This bug seems to exist since the beginning of the SIT driver (24 years!): >>> https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a >>> Search addrconf_set_dstaddr() >>> >>> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> >>> >> >> A patch was sent yesterday, "sit: set name of device back to struct >> parms", to set the name field in params. >> > Oh yes, it was in my spam folder ... > Really a question for zhang kai about the patches - why both of these. And from there how did this ever work? addrconf_set_sit_dstaddr should have been failing for the last 24 years so why fix it vs just ripping it out.
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index b0ef65eb9..4c6b3fc7e 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev, if (err) return err; - dev = __dev_get_by_name(net, p.name); - if (!dev) - return -ENOBUFS; return dev_open(dev, NULL); }
so do not check it. Signed-off-by: zhang kai <zhangkaiheb@126.com> --- net/ipv6/addrconf.c | 3 --- 1 file changed, 3 deletions(-)