diff mbox series

[net-next,v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c

Message ID 20210609070921.1330407-1-libaokun1@huawei.com (mailing list archive)
State Accepted
Commit 39c3783ec062231b6befc193742161af33e17d88
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Baokun Li June 9, 2021, 7:09 a.m. UTC
Using list_move() instead of list_del() + list_add() in nfp_cppcore.c.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
	CC mailist

 .../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Simon Horman June 9, 2021, 8:58 a.m. UTC | #1
On Wed, Jun 09, 2021 at 03:09:21PM +0800, Baokun Li wrote:
> Using list_move() instead of list_del() + list_add() in nfp_cppcore.c.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
patchwork-bot+netdevbpf@kernel.org June 9, 2021, 9:10 p.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 9 Jun 2021 15:09:21 +0800 you wrote:
> Using list_move() instead of list_del() + list_add() in nfp_cppcore.c.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> V1->V2:
> 	CC mailist
> 
> [...]

Here is the summary with links:
  - [net-next,v2] nfp: use list_move instead of list_del/list_add in nfp_cppcore.c
    https://git.kernel.org/netdev/net-next/c/39c3783ec062

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
index 94994a939277..d7ac0307797f 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c
@@ -905,8 +905,7 @@  area_cache_put(struct nfp_cpp *cpp, struct nfp_cpp_area_cache *cache)
 		return;
 
 	/* Move to front of LRU */
-	list_del(&cache->entry);
-	list_add(&cache->entry, &cpp->area_cache_list);
+	list_move(&cache->entry, &cpp->area_cache_list);
 
 	mutex_unlock(&cpp->area_cache_mutex);
 }