| Message ID | 20210610082209.91487-4-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | virtio-net: support xdp socket zero copy | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 15 of 15 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
在 2021/6/10 下午4:21, Xuan Zhuo 写道: > virtio-net not use dma addr directly. So add this priv_flags > IFF_NOT_USE_DMA_ADDR. > > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> > --- > drivers/net/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 0416a7e00914..6c1233f0ab3e 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -3064,7 +3064,7 @@ static int virtnet_probe(struct virtio_device *vdev) > > /* Set up network device as normal. */ > dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE | > - IFF_TX_SKB_NO_LINEAR; > + IFF_TX_SKB_NO_LINEAR | IFF_NOT_USE_DMA_ADDR; I wonder instead of doing trick like this, how about teach the virtio core to accept DMA address via sg? Thanks > dev->netdev_ops = &virtnet_netdev; > dev->features = NETIF_F_HIGHDMA; >
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0416a7e00914..6c1233f0ab3e 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -3064,7 +3064,7 @@ static int virtnet_probe(struct virtio_device *vdev) /* Set up network device as normal. */ dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE | - IFF_TX_SKB_NO_LINEAR; + IFF_TX_SKB_NO_LINEAR | IFF_NOT_USE_DMA_ADDR; dev->netdev_ops = &virtnet_netdev; dev->features = NETIF_F_HIGHDMA;
virtio-net not use dma addr directly. So add this priv_flags IFF_NOT_USE_DMA_ADDR. Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)