From patchwork Thu Jun 10 14:01:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhongjun Tan X-Patchwork-Id: 12313247 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A691C47094 for ; Thu, 10 Jun 2021 14:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E17D161027 for ; Thu, 10 Jun 2021 14:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbhFJODz (ORCPT ); Thu, 10 Jun 2021 10:03:55 -0400 Received: from m12-11.163.com ([220.181.12.11]:36974 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbhFJODy (ORCPT ); Thu, 10 Jun 2021 10:03:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=2gIa2 ivO7sVTOiyRe5C/PPsVB2sRGVleTFNA1p6NVz4=; b=SHw+0K3MPyzhrZEzfpRfv wl2j8QG0MwDeTNc6W+mxGkHG14Mv6xl98RzmB3uVvfhi1gLtsoOEczTuBGP27doh StjqmNl2FTA/caagwxYgNe/RPMATEwldeQcgPDvp9iMT/iSBFaV9wLOaZXeKuO1m Z3P13wudPyv8vKlXbF3g3M= Received: from localhost.localdomain (unknown [218.17.89.92]) by smtp7 (Coremail) with SMTP id C8CowACHqaFCG8JglYUVhQ--.8453S2; Thu, 10 Jun 2021 22:01:39 +0800 (CST) From: =?utf-8?q?=C2=A0Zhongjun_Tan?= To: elder@kernel.org, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tan Zhongjun Subject: [PATCH] soc: qcom: ipa: Remove superfluous error message around platform_get_irq() Date: Thu, 10 Jun 2021 22:01:18 +0800 Message-Id: <20210610140118.1437-1-hbut_tan@163.com> X-Mailer: git-send-email 2.30.0.windows.2 MIME-Version: 1.0 X-CM-TRANSID: C8CowACHqaFCG8JglYUVhQ--.8453S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrykKFy7tryDZw1furWDtwb_yoWfuFc_Kr 9rZF1fWa95ur4Sy3yUZrWfZFy7tw1UZry0gry2v3yS9ry5AF1UJr1DuryfJF4SkrWUCr9r CryxGrWIyr9rujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeAsqJUUUUU== X-Originating-IP: [218.17.89.92] X-CM-SenderInfo: xkex3sxwdqqiywtou0bp/1tbiSButxl+Fa+F2AAAAse Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Tan Zhongjun The platform_get_irq() prints error message telling that interrupt is missing,hence there is no need to duplicated that message in the drivers. Signed-off-by: Tan Zhongjun --- drivers/net/ipa/ipa_smp2p.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c index 34b68dc43886..93270e50b6b3 100644 --- a/drivers/net/ipa/ipa_smp2p.c +++ b/drivers/net/ipa/ipa_smp2p.c @@ -177,11 +177,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name, int ret; ret = platform_get_irq_byname(smp2p->ipa->pdev, name); - if (ret <= 0) { - dev_err(dev, "DT error %d getting \"%s\" IRQ property\n", - ret, name); + if (ret <= 0) return ret ? : -EINVAL; - } irq = ret; ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p);