| Message ID | 20210611045049.3905429-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: hkallweit1@gmail.com linux@armlinux.org.uk |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 18 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
> Use devm_platform_get_and_ioremap_resource() to simplify > code. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > v2: > only convert the first platform_get_resource() > --- > drivers/net/mdio/mdio-mscc-miim.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c > index b36e5ea04ddf..071c654bab29 100644 > --- a/drivers/net/mdio/mdio-mscc-miim.c > +++ b/drivers/net/mdio/mdio-mscc-miim.c > @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct platform_device *pdev) > struct mscc_miim_dev *dev; > int ret; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return -ENODEV; > - > bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev)); > if (!bus) > return -ENOMEM; > @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device *pdev) > bus->parent = &pdev->dev; > > dev = bus->priv; > - dev->regs = devm_ioremap_resource(&pdev->dev, res); > + dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); res not used later, so should be dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); > if (IS_ERR(dev->regs)) { > dev_err(&pdev->dev, "Unable to map MIIM registers\n"); > return PTR_ERR(dev->regs);
On 2021/6/11 14:57, weiyongjun (A) wrote: > >> Use devm_platform_get_and_ioremap_resource() to simplify >> code. >> >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> --- >> v2: >> only convert the first platform_get_resource() >> --- >> drivers/net/mdio/mdio-mscc-miim.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/net/mdio/mdio-mscc-miim.c >> b/drivers/net/mdio/mdio-mscc-miim.c >> index b36e5ea04ddf..071c654bab29 100644 >> --- a/drivers/net/mdio/mdio-mscc-miim.c >> +++ b/drivers/net/mdio/mdio-mscc-miim.c >> @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct >> platform_device *pdev) >> struct mscc_miim_dev *dev; >> int ret; >> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (!res) >> - return -ENODEV; >> - >> bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev)); >> if (!bus) >> return -ENOMEM; >> @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device >> *pdev) >> bus->parent = &pdev->dev; >> dev = bus->priv; >> - dev->regs = devm_ioremap_resource(&pdev->dev, res); >> + dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > > > res not used later, so should be > > dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); Yes, I will send a v3 later. Thanks, Yang > > >> if (IS_ERR(dev->regs)) { >> dev_err(&pdev->dev, "Unable to map MIIM registers\n"); >> return PTR_ERR(dev->regs); > .
diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c index b36e5ea04ddf..071c654bab29 100644 --- a/drivers/net/mdio/mdio-mscc-miim.c +++ b/drivers/net/mdio/mdio-mscc-miim.c @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct platform_device *pdev) struct mscc_miim_dev *dev; int ret; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev)); if (!bus) return -ENOMEM; @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device *pdev) bus->parent = &pdev->dev; dev = bus->priv; - dev->regs = devm_ioremap_resource(&pdev->dev, res); + dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(dev->regs)) { dev_err(&pdev->dev, "Unable to map MIIM registers\n"); return PTR_ERR(dev->regs);
Use devm_platform_get_and_ioremap_resource() to simplify code. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- v2: only convert the first platform_get_resource() --- drivers/net/mdio/mdio-mscc-miim.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)