| Message ID | 20210617041446.425283-1-andrii@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f20792d425d2efd2680f2855c1e3fec01c2e569e |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] selftests/bpf: fix selftests build with old system-wide headers | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 2 blamed authors not CCed: kafai@fb.com edumazet@google.com; 9 maintainers not CCed: linux-kselftest@vger.kernel.org yhs@fb.com kpsingh@kernel.org kafai@fb.com ast@kernel.org john.fastabend@gmail.com songliubraving@fb.com shuah@kernel.org edumazet@google.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
From: Andrii Nakryiko <andrii@kernel.org> Date: Wed, 16 Jun 2021 21:14:46 -0700 > migrate_reuseport.c selftest relies on having TCP_FASTOPEN_CONNECT defined in > system-wide netinet/tcp.h. Selftests can use up-to-date uapi/linux/tcp.h, but > that one doesn't have SOL_TCP. So instead of switching everything to uapi > header, add #define for TCP_FASTOPEN_CONNECT to fix the build. Acked-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp> Thank you!
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 16 Jun 2021 21:14:46 -0700 you wrote: > migrate_reuseport.c selftest relies on having TCP_FASTOPEN_CONNECT defined in > system-wide netinet/tcp.h. Selftests can use up-to-date uapi/linux/tcp.h, but > that one doesn't have SOL_TCP. So instead of switching everything to uapi > header, add #define for TCP_FASTOPEN_CONNECT to fix the build. > > Cc: Kuniyuki Iwashima <kuniyu@amazon.co.jp> > Fixes: c9d0bdef89a6 ("bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.") > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> > > [...] Here is the summary with links: - [bpf-next] selftests/bpf: fix selftests build with old system-wide headers https://git.kernel.org/bpf/bpf-next/c/f20792d425d2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c index 0fa3f750567d..59adb4715394 100644 --- a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c +++ b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c @@ -30,6 +30,10 @@ #include "test_migrate_reuseport.skel.h" #include "network_helpers.h" +#ifndef TCP_FASTOPEN_CONNECT +#define TCP_FASTOPEN_CONNECT 30 +#endif + #define IFINDEX_LO 1 #define NR_SERVERS 5
migrate_reuseport.c selftest relies on having TCP_FASTOPEN_CONNECT defined in system-wide netinet/tcp.h. Selftests can use up-to-date uapi/linux/tcp.h, but that one doesn't have SOL_TCP. So instead of switching everything to uapi header, add #define for TCP_FASTOPEN_CONNECT to fix the build. Cc: Kuniyuki Iwashima <kuniyu@amazon.co.jp> Fixes: c9d0bdef89a6 ("bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.") Signed-off-by: Andrii Nakryiko <andrii@kernel.org> --- tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 4 ++++ 1 file changed, 4 insertions(+)