| Message ID | 20210621134902.83587-10-coiby.xu@gmail.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | Improve the qlge driver based on drivers/staging/qlge/TODO | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
diff --git a/drivers/staging/qlge/TODO b/drivers/staging/qlge/TODO index cc5f8cf7608d..2c4cc586a4bf 100644 --- a/drivers/staging/qlge/TODO +++ b/drivers/staging/qlge/TODO @@ -6,7 +6,6 @@ split cases. * the driver has a habit of using runtime checks where compile time checks are possible (ex. ql_free_rx_buffers(), ql_alloc_rx_buffers()) -* reorder struct members to avoid holes if it doesn't impact performance * avoid legacy/deprecated apis (ex. replace pci_dma_*, replace pci_enable_msi, use pci_iomap) * some "while" loops could be rewritten with simple "for", ex.
struct qlge_cq has one hole, but for the sake of readability (irq is one of the Misc. handler elements, don't move it from after 'irq' to after 'cnsmr_idx' ), keep it untouched. Then, there is no struct that need reordering according to pahole. Signed-off-by: Coiby Xu <coiby.xu@gmail.com> --- drivers/staging/qlge/TODO | 1 - 1 file changed, 1 deletion(-)