| Message ID | 20210621134902.83587-8-coiby.xu@gmail.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | Improve the qlge driver based on drivers/staging/qlge/TODO | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
diff --git a/drivers/staging/qlge/TODO b/drivers/staging/qlge/TODO index 8c84160b5993..cc5f8cf7608d 100644 --- a/drivers/staging/qlge/TODO +++ b/drivers/staging/qlge/TODO @@ -4,8 +4,6 @@ ql_build_rx_skb(). That function is now used exclusively to handle packets that underwent header splitting but it still contains code to handle non split cases. -* some structures are initialized redundantly (ex. memset 0 after - alloc_etherdev()) * the driver has a habit of using runtime checks where compile time checks are possible (ex. ql_free_rx_buffers(), ql_alloc_rx_buffers()) * reorder struct members to avoid holes if it doesn't impact performance
commit 953b94009377419f28fd0153f91fcd5b5a347608 ("staging: qlge: Initialize devlink health dump framework") removed the unnecessary memset 0 after alloc_etherdev_mq. Delete this TODO item. Signed-off-by: Coiby Xu <coiby.xu@gmail.com> --- drivers/staging/qlge/TODO | 2 -- 1 file changed, 2 deletions(-)