| Message ID | 20210707060328.3133074-1-Jianlin.Lv@arm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] bpf: runqslower: fixed make install issue | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: jolsa@redhat.com jean-philippe@linaro.org sedat.dilek@gmail.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 31 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, Jul 6, 2021 at 11:03 PM Jianlin Lv <Jianlin.Lv@arm.com> wrote: > > runqslower did not define install target, resulting in an installation > tool/bpf error: > $ make -C tools/bpf/ install > > make[1]: Entering directory './tools/bpf/runqslower' > make[1]: *** No rule to make target 'install'. Stop. > > Add install target for runqslower. > > Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com> Andrii applied a patch that removed install target. I don't mind whichever way.
diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile index 3818ec511fd2..7dd0ae982459 100644 --- a/tools/bpf/runqslower/Makefile +++ b/tools/bpf/runqslower/Makefile @@ -1,6 +1,8 @@ # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) include ../../scripts/Makefile.include +prefix ?= /usr/local + OUTPUT ?= $(abspath .output)/ BPFTOOL_OUTPUT := $(OUTPUT)bpftool/ @@ -31,9 +33,11 @@ MAKEFLAGS += --no-print-directory submake_extras := feature_display=0 endif +INSTALL ?= install + .DELETE_ON_ERROR: -.PHONY: all clean runqslower +.PHONY: all clean runqslower install all: runqslower runqslower: $(OUTPUT)/runqslower @@ -46,6 +50,11 @@ clean: $(Q)$(RM) $(OUTPUT)runqslower $(Q)$(RM) -r .output +install: $(OUTPUT)/runqslower + $(call QUIET_INSTALL, runqslower) + $(Q)$(INSTALL) -m 0755 -d $(DESTDIR)$(prefix)/sbin + $(Q)$(INSTALL) $(OUTPUT)runqslower $(DESTDIR)$(prefix)/sbin/runqslower + $(OUTPUT)/runqslower: $(OUTPUT)/runqslower.o $(BPFOBJ) $(QUIET_LINK)$(CC) $(CFLAGS) $^ -lelf -lz -o $@
runqslower did not define install target, resulting in an installation tool/bpf error: $ make -C tools/bpf/ install make[1]: Entering directory './tools/bpf/runqslower' make[1]: *** No rule to make target 'install'. Stop. Add install target for runqslower. Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com> --- tools/bpf/runqslower/Makefile | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)