| Message ID | 20210712192450.GA1153790@pc (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | replace for loop with array initializer | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | CHECK: spaces preferred around that '-' (ctx:VxV) WARNING: line length of 96 exceeds 80 columns |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, 12 Jul 2021 20:24:50 +0100 Salah Triki <salah.triki@gmail.com> wrote: > diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c > index b3466e084e84..a90d3b9a8170 100644 > --- a/drivers/net/wan/farsync.c > +++ b/drivers/net/wan/farsync.c > @@ -567,7 +567,7 @@ static void fst_process_int_work_q(struct tasklet_struct *unused); > static DECLARE_TASKLET(fst_tx_task, fst_process_tx_work_q); > static DECLARE_TASKLET(fst_int_task, fst_process_int_work_q); > > -static struct fst_card_info *fst_card_array[FST_MAX_CARDS]; > +static struct fst_card_info *fst_card_array[FST_MAX_CARDS] = { [0 ... FST_MAX_CARDS-1] = NULL }; Why bother, the default initialization in C is 0 (ie. NULL). In fact, checkpatch should complain about useless array initialization for this.
On Mon, 2021-07-12 at 13:05 -0700, Stephen Hemminger wrote: > On Mon, 12 Jul 2021 20:24:50 +0100 Salah Triki <salah.triki@gmail.com> wrote: > > diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c [] > > +static struct fst_card_info *fst_card_array[FST_MAX_CARDS] = { [0 ... FST_MAX_CARDS-1] = NULL }; > > Why bother, the default initialization in C is 0 (ie. NULL). > In fact, checkpatch should complain about useless array initialization for this. I'll look out for your patch to checkpatch.
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c index b3466e084e84..a90d3b9a8170 100644 --- a/drivers/net/wan/farsync.c +++ b/drivers/net/wan/farsync.c @@ -567,7 +567,7 @@ static void fst_process_int_work_q(struct tasklet_struct *unused); static DECLARE_TASKLET(fst_tx_task, fst_process_tx_work_q); static DECLARE_TASKLET(fst_int_task, fst_process_int_work_q); -static struct fst_card_info *fst_card_array[FST_MAX_CARDS]; +static struct fst_card_info *fst_card_array[FST_MAX_CARDS] = { [0 ... FST_MAX_CARDS-1] = NULL }; static DEFINE_SPINLOCK(fst_work_q_lock); static u64 fst_work_txq; static u64 fst_work_intq; @@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = { static int __init fst_init(void) { - int i; - - for (i = 0; i < FST_MAX_CARDS; i++) - fst_card_array[i] = NULL; return pci_register_driver(&fst_driver); }
Replace for loop with array initializer in order to make code more clean. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- drivers/net/wan/farsync.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)