| Message ID | 20210712205848.GA1492971@pc (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | delete useless for loop | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello Salah, On Mon, Jul 12, 2021 at 09:58:48PM +0100, Salah Triki wrote: > Delete useless initialization of fst_card_array since the default > initialization is NULL. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > drivers/net/wan/farsync.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c > index b3466e084e84..0b3f561d5d5e 100644 > --- a/drivers/net/wan/farsync.c > +++ b/drivers/net/wan/farsync.c > @@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = { > static int __init > fst_init(void) > { > - int i; > - > - for (i = 0; i < FST_MAX_CARDS; i++) > - fst_card_array[i] = NULL; > return pci_register_driver(&fst_driver); > } Looks right. I wonder if it makes sense to go even further and let farsync.c use module_pci_driver. Best regards Uwe
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c index b3466e084e84..0b3f561d5d5e 100644 --- a/drivers/net/wan/farsync.c +++ b/drivers/net/wan/farsync.c @@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = { static int __init fst_init(void) { - int i; - - for (i = 0; i < FST_MAX_CARDS; i++) - fst_card_array[i] = NULL; return pci_register_driver(&fst_driver); }
Delete useless initialization of fst_card_array since the default initialization is NULL. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- drivers/net/wan/farsync.c | 4 ---- 1 file changed, 4 deletions(-)