| Message ID | 20210713102719.8890-1-tklauser@distanz.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de587d564f957b685e47da1848d428b86173766d |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] selftests/bpf: remove unused variable in tc_tunnel prog | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 9 maintainers not CCed: linux-kselftest@vger.kernel.org netdev@vger.kernel.org yhs@fb.com kpsingh@kernel.org huangxuesen@kuaishou.com kafai@fb.com john.fastabend@gmail.com songliubraving@fb.com shuah@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, Jul 13, 2021 at 12:27 PM Tobias Klauser <tklauser@distanz.ch> wrote: > > The variable buf is unused since commit 005edd16562b ("selftests/bpf: > convert bpf tunnel test to BPF_ADJ_ROOM_MAC"). Remove it to fix the > following warning: > > test_tc_tunnel.c:531:7: warning: unused variable 'buf' [-Wunused-variable] > > Fixes: 005edd16562b ("selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC") > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Acked-by: Willem de Bruijn <willemb@google.com> Thanks for the fix, Tobias.
Willem de Bruijn wrote: > On Tue, Jul 13, 2021 at 12:27 PM Tobias Klauser <tklauser@distanz.ch> wrote: > > > > The variable buf is unused since commit 005edd16562b ("selftests/bpf: > > convert bpf tunnel test to BPF_ADJ_ROOM_MAC"). Remove it to fix the > > following warning: > > > > test_tc_tunnel.c:531:7: warning: unused variable 'buf' [-Wunused-variable] > > > > Fixes: 005edd16562b ("selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC") > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > > Acked-by: Willem de Bruijn <willemb@google.com> > > Thanks for the fix, Tobias. Acked-by: John Fastabend <john.fastabend@gmail.com>
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 13 Jul 2021 12:27:19 +0200 you wrote: > The variable buf is unused since commit 005edd16562b ("selftests/bpf: > convert bpf tunnel test to BPF_ADJ_ROOM_MAC"). Remove it to fix the > following warning: > > test_tc_tunnel.c:531:7: warning: unused variable 'buf' [-Wunused-variable] > > Fixes: 005edd16562b ("selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC") > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > > [...] Here is the summary with links: - [bpf-next] selftests/bpf: remove unused variable in tc_tunnel prog https://git.kernel.org/bpf/bpf-next/c/de587d564f95 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/testing/selftests/bpf/progs/test_tc_tunnel.c b/tools/testing/selftests/bpf/progs/test_tc_tunnel.c index 84cd63259554..a0e7762b1e5a 100644 --- a/tools/testing/selftests/bpf/progs/test_tc_tunnel.c +++ b/tools/testing/selftests/bpf/progs/test_tc_tunnel.c @@ -528,7 +528,6 @@ int __encap_ip6vxlan_eth(struct __sk_buff *skb) static int decap_internal(struct __sk_buff *skb, int off, int len, char proto) { - char buf[sizeof(struct v6hdr)]; struct gre_hdr greh; struct udphdr udph; int olen = len;
The variable buf is unused since commit 005edd16562b ("selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC"). Remove it to fix the following warning: test_tc_tunnel.c:531:7: warning: unused variable 'buf' [-Wunused-variable] Fixes: 005edd16562b ("selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC") Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- tools/testing/selftests/bpf/progs/test_tc_tunnel.c | 1 - 1 file changed, 1 deletion(-)