diff mbox series

[net] net/tcp_fastopen: remove obsolete extern

Message ID 20210719092028.3016745-1-eric.dumazet@gmail.com (mailing list archive)
State Accepted
Commit 749468760b952e555529ca8a71256b991455101e
Delegated to: Netdev Maintainers
Headers show
Series [net] net/tcp_fastopen: remove obsolete extern | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net
netdev/subject_prefix success Link
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 1037 this patch: 1037
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 1040 this patch: 1040
netdev/header_inline success Link

Commit Message

Eric Dumazet July 19, 2021, 9:20 a.m. UTC
From: Eric Dumazet <edumazet@google.com>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
a global variable.

Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Cc: Wei Wang <weiwan@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
---
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Wei Wang July 19, 2021, 3:43 p.m. UTC | #1
On Mon, Jul 19, 2021 at 2:20 AM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
> a global variable.
>
> Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> Cc: Wei Wang <weiwan@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> ---

Acked-by: Wei Wang <weiwan@google.com>

>  include/net/tcp.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/tcp.h b/include/net/tcp.h
> index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
> --- a/include/net/tcp.h
> +++ b/include/net/tcp.h
> @@ -1709,7 +1709,6 @@ struct tcp_fastopen_context {
>         struct rcu_head rcu;
>  };
>
> -extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
>  void tcp_fastopen_active_disable(struct sock *sk);
>  bool tcp_fastopen_active_should_disable(struct sock *sk);
>  void tcp_fastopen_active_disable_ofo_check(struct sock *sk);
> --
> 2.32.0.402.g57bb445576-goog
>
patchwork-bot+netdevbpf@kernel.org July 20, 2021, 10:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 19 Jul 2021 02:20:28 -0700 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
> a global variable.
> 
> Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> Cc: Wei Wang <weiwan@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> 
> [...]

Here is the summary with links:
  - [net] net/tcp_fastopen: remove obsolete extern
    https://git.kernel.org/netdev/net/c/749468760b95

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1709,7 +1709,6 @@  struct tcp_fastopen_context {
 	struct rcu_head	rcu;
 };
 
-extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
 void tcp_fastopen_active_disable(struct sock *sk);
 bool tcp_fastopen_active_should_disable(struct sock *sk);
 void tcp_fastopen_active_disable_ofo_check(struct sock *sk);