diff mbox series

[net-next] tcp: avoid indirect call in tcp_new_space()

Message ID 20210721090614.68297-1-eric.dumazet@gmail.com (mailing list archive)
State Accepted
Commit 739b2adf99e99f076601df412ec9aa92302c701f
Delegated to: Netdev Maintainers
Headers show
Series [net-next] tcp: avoid indirect call in tcp_new_space() | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 2 maintainers not CCed: yoshfuji@linux-ipv6.org dsahern@kernel.org
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit fail Errors and warnings before: 8 this patch: 8
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_allmodconfig_warn fail Errors and warnings before: 8 this patch: 6
netdev/header_inline success Link

Commit Message

Eric Dumazet July 21, 2021, 9:06 a.m. UTC 
From: Eric Dumazet <edumazet@google.com>

For tcp sockets, sk->sk_write_space is most probably sk_stream_write_space().

Other sk->sk_write_space() calls in TCP are slow path and do not deserve
any change.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv4/tcp_input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 21, 2021, 4:10 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 21 Jul 2021 02:06:14 -0700 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> For tcp sockets, sk->sk_write_space is most probably sk_stream_write_space().
> 
> Other sk->sk_write_space() calls in TCP are slow path and do not deserve
> any change.
> 
> [...]

Here is the summary with links:
  - [net-next] tcp: avoid indirect call in tcp_new_space()
    https://git.kernel.org/netdev/net-next/c/739b2adf99e9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 149ceb5c94ffcd4499d3054fae31bd296a9e0bcd..bef2c8b64d83a0f3d4cca90f9b12912bf3d00807 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -5383,7 +5383,7 @@  static void tcp_new_space(struct sock *sk)
 		tp->snd_cwnd_stamp = tcp_jiffies32;
 	}
 
-	sk->sk_write_space(sk);
+	INDIRECT_CALL_1(sk->sk_write_space, sk_stream_write_space, sk);
 }
 
 static void tcp_check_space(struct sock *sk)