diff mbox series

bpf: remove redundant intiialization of variable stype

Message ID 20210721115630.109279-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 724f17b7d45d62c71e92471666647a823cb9baa9
Delegated to: BPF
Headers show
Series bpf: remove redundant intiialization of variable stype | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Colin King July 21, 2021, 11:56 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable stype is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 kernel/bpf/local_storage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 22, 2021, 11:50 p.m. UTC | #1 
Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Wed, 21 Jul 2021 12:56:30 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable stype is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> [...]

Here is the summary with links:
  - bpf: remove redundant intiialization of variable stype
    https://git.kernel.org/bpf/bpf-next/c/724f17b7d45d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/kernel/bpf/local_storage.c b/kernel/bpf/local_storage.c
index 362e81481594..7ed2a14dc0de 100644
--- a/kernel/bpf/local_storage.c
+++ b/kernel/bpf/local_storage.c
@@ -406,7 +406,7 @@  static int cgroup_storage_check_btf(const struct bpf_map *map,
 static void cgroup_storage_seq_show_elem(struct bpf_map *map, void *key,
 					 struct seq_file *m)
 {
-	enum bpf_cgroup_storage_type stype = cgroup_storage_type(map);
+	enum bpf_cgroup_storage_type stype;
 	struct bpf_cgroup_storage *storage;
 	int cpu;