| Message ID | 20210801151659.146113-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a6afdb041a2d7f514711b3bd27227e83d3cd9cf4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | qlcnic: make the array random_data static const, makes object smaller | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 1 Aug 2021 16:16:59 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the array random_data on the stack but instead it > static const. Makes the object code smaller by 66 bytes. > > Before: > text data bss dec hex filename > 52895 10976 0 63871 f97f ../qlogic/qlcnic/qlcnic_ethtool.o > > [...] Here is the summary with links: - qlcnic: make the array random_data static const, makes object smaller https://git.kernel.org/netdev/net-next/c/a6afdb041a2d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index d8f0863b3934..f6b6651decf3 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1021,7 +1021,7 @@ static int qlcnic_irq_test(struct net_device *netdev) static void qlcnic_create_loopback_buff(unsigned char *data, u8 mac[]) { - unsigned char random_data[] = {0xa8, 0x06, 0x45, 0x00}; + static const unsigned char random_data[] = {0xa8, 0x06, 0x45, 0x00}; memset(data, 0x4e, QLCNIC_ILB_PKT_SIZE);