| Message ID | 20210802035745.29934-1-yajun.deng@linux.dev (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] neighbour: Rename procfs entry | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 7 maintainers not CCed: dsahern@kernel.org yang.lee@linux.alibaba.com trix@redhat.com jdike@akamai.com chinagar@codeaurora.org zhutong@amazon.com weichen.chen@linux.alibaba.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | Link |
On Mon, 2 Aug 2021 11:57:45 +0800 Yajun Deng wrote: > Use gc_thresh_{min, default, max} instead of gc_thresh{1, 2, 3}. > This is more friendly for user. We can't rename files in procfs after they had been present in an official kernel release. They are uABI. Same goes for your default -> current rename patch. You also forgot to update documentation.
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index e831b9adf1e4..c294addb7818 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -3595,7 +3595,7 @@ static struct neigh_sysctl_table { .proc_handler = proc_dointvec_jiffies, }, [NEIGH_VAR_GC_THRESH1] = { - .procname = "gc_thresh1", + .procname = "gc_thresh_min", .maxlen = sizeof(int), .mode = 0644, .extra1 = SYSCTL_ZERO, @@ -3603,7 +3603,7 @@ static struct neigh_sysctl_table { .proc_handler = proc_dointvec_minmax, }, [NEIGH_VAR_GC_THRESH2] = { - .procname = "gc_thresh2", + .procname = "gc_thresh_default", .maxlen = sizeof(int), .mode = 0644, .extra1 = SYSCTL_ZERO, @@ -3611,7 +3611,7 @@ static struct neigh_sysctl_table { .proc_handler = proc_dointvec_minmax, }, [NEIGH_VAR_GC_THRESH3] = { - .procname = "gc_thresh3", + .procname = "gc_thresh_max", .maxlen = sizeof(int), .mode = 0644, .extra1 = SYSCTL_ZERO,
Use gc_thresh_{min, default, max} instead of gc_thresh{1, 2, 3}. This is more friendly for user. Signed-off-by: Yajun Deng <yajun.deng@linux.dev> --- net/core/neighbour.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)