| Message ID | 20210803073739.22339-1-yajun.deng@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bebc3bbf5131b7f792b207e8fcac9a798bb23bbf |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: decnet: Fix refcount warning for new dn_fib_info | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 8/3/21 1:37 AM, Yajun Deng wrote: > fib_treeref needs to be set after kzalloc. The old code had a ++ which > led to the confusion when the int was replaced by a refcount_t. > > Fixes: 79976892f7ea ("net: convert fib_treeref from int to refcount_t") > Signed-off-by: Yajun Deng <yajun.deng@linux.dev> > --- > net/decnet/dn_fib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 3 Aug 2021 15:37:39 +0800 you wrote: > fib_treeref needs to be set after kzalloc. The old code had a ++ which > led to the confusion when the int was replaced by a refcount_t. > > Fixes: 79976892f7ea ("net: convert fib_treeref from int to refcount_t") > Signed-off-by: Yajun Deng <yajun.deng@linux.dev> > --- > net/decnet/dn_fib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: decnet: Fix refcount warning for new dn_fib_info https://git.kernel.org/netdev/net-next/c/bebc3bbf5131 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c index 387a7e81dd00..153a5fc1bdde 100644 --- a/net/decnet/dn_fib.c +++ b/net/decnet/dn_fib.c @@ -389,7 +389,7 @@ struct dn_fib_info *dn_fib_create_info(const struct rtmsg *r, struct nlattr *att return ofi; } - refcount_inc(&fi->fib_treeref); + refcount_set(&fi->fib_treeref, 1); refcount_set(&fi->fib_clntref, 1); spin_lock(&dn_fib_info_lock); fi->fib_next = dn_fib_info_list;
fib_treeref needs to be set after kzalloc. The old code had a ++ which led to the confusion when the int was replaced by a refcount_t. Fixes: 79976892f7ea ("net: convert fib_treeref from int to refcount_t") Signed-off-by: Yajun Deng <yajun.deng@linux.dev> --- net/decnet/dn_fib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)