Message ID | 20210803162739.2363542-1-richardsonnick@google.com (mailing list archive) |
---|---|
State | Accepted |
Commit | c2eecaa193ff1e516a1b389637169ae86a6fa867 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [v4] pktgen: Remove redundant clone_skb override | expand |
Context | Check | Description |
---|---|---|
netdev/cover_letter | success | Link |
netdev/fixes_present | success | Link |
netdev/patch_count | success | Link |
netdev/tree_selection | success | Guessed tree name to be net-next |
netdev/subject_prefix | warning | Target tree name not specified in the subject |
netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
netdev/source_inline | success | Was 0 now: 0 |
netdev/verify_signedoff | success | Link |
netdev/module_param | success | Was 0 now: 0 |
netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
netdev/verify_fixes | success | Link |
netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 11 lines checked |
netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 3 Aug 2021 16:27:35 +0000 you wrote: > From: Nick Richardson <richardsonnick@google.com> > > When the netif_receive xmit_mode is set, a line is supposed to set > clone_skb to a default 0 value. This line is made redundant due to a > preceding line that checks if clone_skb is more than zero and returns > -ENOTSUPP. > > [...] Here is the summary with links: - [v4] pktgen: Remove redundant clone_skb override https://git.kernel.org/netdev/net-next/c/c2eecaa193ff You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 7e258d255e90..314f97acf39d 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1190,11 +1190,6 @@ static ssize_t pktgen_if_write(struct file *file, * pktgen_xmit() is called */ pkt_dev->last_ok = 1; - - /* override clone_skb if user passed default value - * at module loading time - */ - pkt_dev->clone_skb = 0; } else if (strcmp(f, "queue_xmit") == 0) { pkt_dev->xmit_mode = M_QUEUE_XMIT; pkt_dev->last_ok = 1;