diff mbox series

[next] mctp: remove duplicated assignment of pointer hdr

Message ID 20210804121530.110521-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit df7ba0eb25edded52b1b3f6bb6ab0c0048a7e0bb
Delegated to: Netdev Maintainers
Headers show
Series [next] mctp: remove duplicated assignment of pointer hdr | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Colin King Aug. 4, 2021, 12:15 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The pointer hdr is being initialized and also re-assigned with the
same value from the call to function mctp_hdr. Static analysis reports
that the initializated value is unused. The second assignment is
duplicated and can be removed.

Addresses-Coverity: ("Unused value").
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/mctp/af_mctp.c | 1 -
 1 file changed, 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 5, 2021, 10 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed,  4 Aug 2021 13:15:30 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer hdr is being initialized and also re-assigned with the
> same value from the call to function mctp_hdr. Static analysis reports
> that the initializated value is unused. The second assignment is
> duplicated and can be removed.
> 
> [...]

Here is the summary with links:
  - [next] mctp: remove duplicated assignment of pointer hdr
    https://git.kernel.org/netdev/net-next/c/df7ba0eb25ed

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c
index 84f722d31fd7..a9526ac29dff 100644
--- a/net/mctp/af_mctp.c
+++ b/net/mctp/af_mctp.c
@@ -170,7 +170,6 @@  static int mctp_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
 		/* TODO: expand mctp_skb_cb for header fields? */
 		struct mctp_hdr *hdr = mctp_hdr(skb);
 
-		hdr = mctp_hdr(skb);
 		addr = msg->msg_name;
 		addr->smctp_family = AF_MCTP;
 		addr->smctp_network = cb->net;