| Message ID | 20210818022215.5979-1-fankaixi.li@bytedance.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 01634047bf0d5c2d9b7d8095bb4de1663dbeedeb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ovs: clear skb->tstamp in forwarding path | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: davem@davemloft.net kuba@kernel.org pshelar@ovn.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 8/18/21 4:22 AM, fankaixi.li@bytedance.com wrote: > From: kaixi.fan <fankaixi.li@bytedance.com> > > fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs > doesn't clear skb->tstamp. We encountered a problem with linux > version 5.4.56 and ovs version 2.14.1, and packets failed to > dequeue from qdisc when fq qdisc was attached to ovs port. > Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC") This is more precise than " version 5.4.56 and ovs version ..." Thanks. > Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com> > Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance.com> > Reviewed-by: Cong Wang <cong.wang@bytedance.com> > --- > net/openvswitch/vport.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index 88deb5b41429..cf2ce5812489 100644 > --- a/net/openvswitch/vport.c > +++ b/net/openvswitch/vport.c > @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto) > } > > skb->dev = vport->dev; > + skb->tstamp = 0; > vport->ops->send(skb); > return; > >
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 18 Aug 2021 10:22:15 +0800 you wrote: > From: kaixi.fan <fankaixi.li@bytedance.com> > > fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs > doesn't clear skb->tstamp. We encountered a problem with linux > version 5.4.56 and ovs version 2.14.1, and packets failed to > dequeue from qdisc when fq qdisc was attached to ovs port. > > [...] Here is the summary with links: - ovs: clear skb->tstamp in forwarding path https://git.kernel.org/netdev/net/c/01634047bf0d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Eric Dumazet <eric.dumazet@gmail.com> 于2021年8月18日周三 下午5:32写道： > > > > On 8/18/21 4:22 AM, fankaixi.li@bytedance.com wrote: > > From: kaixi.fan <fankaixi.li@bytedance.com> > > > > fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs > > doesn't clear skb->tstamp. We encountered a problem with linux > > version 5.4.56 and ovs version 2.14.1, and packets failed to > > dequeue from qdisc when fq qdisc was attached to ovs port. > > > > Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC") > > This is more precise than " version 5.4.56 and ovs version ..." > > Thanks. > > > Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com> > > Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance.com> > > Reviewed-by: Cong Wang <cong.wang@bytedance.com> > > --- > > net/openvswitch/vport.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > > index 88deb5b41429..cf2ce5812489 100644 > > --- a/net/openvswitch/vport.c > > +++ b/net/openvswitch/vport.c > > @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto) > > } > > > > skb->dev = vport->dev; > > + skb->tstamp = 0; > > vport->ops->send(skb); > > return; > > > > Hi Eric Dumazet, Yes and many thanks.
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 88deb5b41429..cf2ce5812489 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto) } skb->dev = vport->dev; + skb->tstamp = 0; vport->ops->send(skb); return;