| Message ID | 20210818130927.33895-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9e5f10fe577be7974c721c0c2050fa6c967d4565 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] octeontx2-af: remove redudant second error check on variable err | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: hkelam@marvell.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 5 this patch: 5 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 18 Aug 2021 14:09:27 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > A recent change added error checking messages and failed to remove one > of the previous error checks. There are now two checks on variable err > so the second one is redundant dead code and can be removed. > > Addresses-Coverity: ("Logically dead code") > Fixes: a83bdada06bf ("octeontx2-af: Add debug messages for failures") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - [next] octeontx2-af: remove redudant second error check on variable err https://git.kernel.org/netdev/net-next/c/9e5f10fe577b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c index fb50df93b54e..c2438ba5e2ec 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c @@ -1031,8 +1031,6 @@ static int rvu_setup_hw_resources(struct rvu *rvu) "%s: Failed to allocate CPT1 LF bitmap\n", __func__); return err; } - if (err) - return err; /* Allocate memory for PFVF data */ rvu->pf = devm_kcalloc(rvu->dev, hw->total_pfs,