diff mbox series

net: ethernet: ti: cpsw: make array stpa static const, makes object smaller

Message ID 20210819120443.7083-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 5c8a2bb481591fc4dbbdb7f79b70d0a36150dd13
Delegated to: Netdev Maintainers
Headers show
Series net: ethernet: ti: cpsw: make array stpa static const, makes object smaller | expand

Checks

Context Check Description
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Colin King Aug. 19, 2021, 12:04 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Don't populate the array stpa on the stack but instead it
static const. Makes the object code smaller by 81 bytes:

Before:
   text    data   bss    dec    hex filename
  54993   17248     0  72241  11a31 ./drivers/net/ethernet/ti/cpsw_new.o

After:
   text    data   bss    dec    hex filename
  54784   17376     0  72160  119e0 ./drivers/net/ethernet/ti/cpsw_new.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/ti/cpsw_new.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 19, 2021, 12:30 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 19 Aug 2021 13:04:43 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the array stpa on the stack but instead it
> static const. Makes the object code smaller by 81 bytes:
> 
> Before:
>    text    data   bss    dec    hex filename
>   54993   17248     0  72241  11a31 ./drivers/net/ethernet/ti/cpsw_new.o
> 
> [...]

Here is the summary with links:
  - net: ethernet: ti: cpsw: make array stpa static const, makes object smaller
    https://git.kernel.org/netdev/net-next/c/5c8a2bb48159

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
index 85d05b9be2b8..534d39f729e2 100644
--- a/drivers/net/ethernet/ti/cpsw_new.c
+++ b/drivers/net/ethernet/ti/cpsw_new.c
@@ -502,7 +502,7 @@  static void cpsw_restore(struct cpsw_priv *priv)
 
 static void cpsw_init_stp_ale_entry(struct cpsw_common *cpsw)
 {
-	char stpa[] = {0x01, 0x80, 0xc2, 0x0, 0x0, 0x0};
+	static const char stpa[] = {0x01, 0x80, 0xc2, 0x0, 0x0, 0x0};
 
 	cpsw_ale_add_mcast(cpsw->ale, stpa,
 			   ALE_PORT_HOST, ALE_SUPER, 0,