diff mbox series

p54: Remove obsolete comment

Message ID 20210901024744.7013-1-wanjiabing@vivo.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series p54: Remove obsolete comment | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Jiabing Wan Sept. 1, 2021, 2:47 a.m. UTC
In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
prism54/isl_oid.h is deleted. The comment here is obsolete.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/wireless/intersil/p54/fwio.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Christian Lamparter Sept. 1, 2021, 5:40 p.m. UTC | #1
On 01/09/2021 04:47, Wan Jiabing wrote:
> In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
> prism54/isl_oid.h is deleted. The comment here is obsolete.
> 
Instead of removing said "obsolete" comment, why not copy the
excellent comment about that "frameburst technology" from the
prism54/isl_oid.h file there?

Cheers,
Christian


> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>   drivers/net/wireless/intersil/p54/fwio.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
> index bece14e4ff0d..1fe072de3e63 100644
> --- a/drivers/net/wireless/intersil/p54/fwio.c
> +++ b/drivers/net/wireless/intersil/p54/fwio.c
> @@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
>   	rtd = 3 * priv->coverage_class;
>   	edcf->slottime += rtd;
>   	edcf->round_trip_delay = cpu_to_le16(rtd);
> -	/* (see prism54/isl_oid.h for further details) */
>   	edcf->frameburst = cpu_to_le16(0);
>   	edcf->flags = 0;
>   	memset(edcf->mapping, 0, sizeof(edcf->mapping));
>
diff mbox series

Patch

diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
index bece14e4ff0d..1fe072de3e63 100644
--- a/drivers/net/wireless/intersil/p54/fwio.c
+++ b/drivers/net/wireless/intersil/p54/fwio.c
@@ -583,7 +583,6 @@  int p54_set_edcf(struct p54_common *priv)
 	rtd = 3 * priv->coverage_class;
 	edcf->slottime += rtd;
 	edcf->round_trip_delay = cpu_to_le16(rtd);
-	/* (see prism54/isl_oid.h for further details) */
 	edcf->frameburst = cpu_to_le16(0);
 	edcf->flags = 0;
 	memset(edcf->mapping, 0, sizeof(edcf->mapping));