| Message ID | 20210902171929.3922667-10-davemarchevsky@fb.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf: implement variadic printk helper | expand |
| Context | Check | Description |
|---|---|---|
| bpf/vmtest-bpf-next | fail | VM_Test |
| bpf/vmtest-bpf-next-PR | fail | PR summary |
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 6 maintainers not CCed: linux-kselftest@vger.kernel.org kpsingh@kernel.org songliubraving@fb.com kafai@fb.com john.fastabend@gmail.com shuah@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: line length of 84 exceeds 80 columns |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Thu, Sep 2, 2021 at 10:23 AM Dave Marchevsky <davemarchevsky@fb.com> wrote: > > This corner case isn't covered by existing selftests' use of bpf_printk. > > Just test compilation, not output, as trace_vprintk already tests > trace_pipe output. > > Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com> > --- > tools/testing/selftests/bpf/progs/trace_vprintk.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/selftests/bpf/progs/trace_vprintk.c b/tools/testing/selftests/bpf/progs/trace_vprintk.c > index 255e2f018efe..33455e48a9ab 100644 > --- a/tools/testing/selftests/bpf/progs/trace_vprintk.c > +++ b/tools/testing/selftests/bpf/progs/trace_vprintk.c > @@ -23,3 +23,10 @@ int sys_enter(void *ctx) > one, 2, three, 4, five, 6, seven, 8, nine, 10, ++trace_vprintk_ran); > return 0; > } > + > +SEC("fentry/__x64_sys_nanosleep") > +int zero_fmt_args(void *ctx) > +{ > + bpf_printk("\t"); // runner doesn't search for this, just ensure it compiles C++ comments :( please use /* */ I'd probably just add this bpf_printk() in the same BPF program above and roll it into previous patch. Doesn't seem like we need dedicated BPF program just for this. > + return 0; > +} > -- > 2.30.2 >
diff --git a/tools/testing/selftests/bpf/progs/trace_vprintk.c b/tools/testing/selftests/bpf/progs/trace_vprintk.c index 255e2f018efe..33455e48a9ab 100644 --- a/tools/testing/selftests/bpf/progs/trace_vprintk.c +++ b/tools/testing/selftests/bpf/progs/trace_vprintk.c @@ -23,3 +23,10 @@ int sys_enter(void *ctx) one, 2, three, 4, five, 6, seven, 8, nine, 10, ++trace_vprintk_ran); return 0; } + +SEC("fentry/__x64_sys_nanosleep") +int zero_fmt_args(void *ctx) +{ + bpf_printk("\t"); // runner doesn't search for this, just ensure it compiles + return 0; +}
This corner case isn't covered by existing selftests' use of bpf_printk. Just test compilation, not output, as trace_vprintk already tests trace_pipe output. Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com> --- tools/testing/selftests/bpf/progs/trace_vprintk.c | 7 +++++++ 1 file changed, 7 insertions(+)