diff mbox series

[13/31] staging: wfx: update with API 3.8

Message ID 20210910160504.1794332-14-Jerome.Pouiller@silabs.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series staging/wfx: usual maintenance | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Jérôme Pouiller Sept. 10, 2021, 4:04 p.m. UTC
From: Jérôme Pouiller <jerome.pouiller@silabs.com>

API 3.8 introduces new statistic counters. These changes are backward
compatible.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
 drivers/staging/wfx/debug.c       | 3 +++
 drivers/staging/wfx/hif_api_mib.h | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Kari Argillander Sept. 10, 2021, 4:43 p.m. UTC | #1
On Fri, Sep 10, 2021 at 06:04:46PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> 
> API 3.8 introduces new statistic counters. These changes are backward
> compatible.

It will be obvious to some what API 3.8 is. But at least me can rise my
hand and admit that I do not. Probably wfx api but ig there is any
public info but it here. If there is not just say Wfx api 3.8.

> 
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
>  drivers/staging/wfx/debug.c       | 3 +++
>  drivers/staging/wfx/hif_api_mib.h | 5 ++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c
> index eedada78c25f..e67ca0d818ba 100644
> --- a/drivers/staging/wfx/debug.c
> +++ b/drivers/staging/wfx/debug.c
> @@ -109,6 +109,9 @@ static int wfx_counters_show(struct seq_file *seq, void *v)
>  
>  	PUT_COUNTER(rx_beacon);
>  	PUT_COUNTER(miss_beacon);
> +	PUT_COUNTER(rx_dtim);
> +	PUT_COUNTER(rx_dtim_aid0_clr);
> +	PUT_COUNTER(rx_dtim_aid0_set);
>  
>  #undef PUT_COUNTER
>  
> diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h
> index ace924720ce6..b2dc47c314cc 100644
> --- a/drivers/staging/wfx/hif_api_mib.h
> +++ b/drivers/staging/wfx/hif_api_mib.h
> @@ -158,7 +158,10 @@ struct hif_mib_extended_count_table {
>  	__le32 count_rx_bipmic_errors;
>  	__le32 count_rx_beacon;
>  	__le32 count_miss_beacon;
> -	__le32 reserved[15];
> +	__le32 count_rx_dtim;
> +	__le32 count_rx_dtim_aid0_clr;
> +	__le32 count_rx_dtim_aid0_set;
> +	__le32 reserved[12];
>  } __packed;
>  
>  struct hif_mib_count_table {
> -- 
> 2.33.0
>
Jérôme Pouiller Sept. 10, 2021, 5:03 p.m. UTC | #2
On Friday 10 September 2021 18:43:26 CEST Kari Argillander wrote:
> 
> On Fri, Sep 10, 2021 at 06:04:46PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >
> > API 3.8 introduces new statistic counters. These changes are backward
> > compatible.
> 
> It will be obvious to some what API 3.8 is. But at least me can rise my
> hand and admit that I do not. Probably wfx api but ig there is any
> public info but it here. If there is not just say Wfx api 3.8.

Indeed. In add, it seems it is not documented in the release note of
the firmware[1] :(. I am going to improve that.

[1] https://github.com/SiliconLabs/wfx-firmware/blob/master/CHANGES.md
diff mbox series

Patch

diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c
index eedada78c25f..e67ca0d818ba 100644
--- a/drivers/staging/wfx/debug.c
+++ b/drivers/staging/wfx/debug.c
@@ -109,6 +109,9 @@  static int wfx_counters_show(struct seq_file *seq, void *v)
 
 	PUT_COUNTER(rx_beacon);
 	PUT_COUNTER(miss_beacon);
+	PUT_COUNTER(rx_dtim);
+	PUT_COUNTER(rx_dtim_aid0_clr);
+	PUT_COUNTER(rx_dtim_aid0_set);
 
 #undef PUT_COUNTER
 
diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h
index ace924720ce6..b2dc47c314cc 100644
--- a/drivers/staging/wfx/hif_api_mib.h
+++ b/drivers/staging/wfx/hif_api_mib.h
@@ -158,7 +158,10 @@  struct hif_mib_extended_count_table {
 	__le32 count_rx_bipmic_errors;
 	__le32 count_rx_beacon;
 	__le32 count_miss_beacon;
-	__le32 reserved[15];
+	__le32 count_rx_dtim;
+	__le32 count_rx_dtim_aid0_clr;
+	__le32 count_rx_dtim_aid0_set;
+	__le32 reserved[12];
 } __packed;
 
 struct hif_mib_count_table {