From patchwork Mon Sep 13 08:30:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12488207 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D18C433FE for ; Mon, 13 Sep 2021 08:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE08760FBF for ; Mon, 13 Sep 2021 08:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238059AbhIMIcZ (ORCPT ); Mon, 13 Sep 2021 04:32:25 -0400 Received: from mail-bn8nam12on2052.outbound.protection.outlook.com ([40.107.237.52]:33696 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S237811AbhIMIcW (ORCPT ); Mon, 13 Sep 2021 04:32:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFFufLEDhM1jEyIieyDRyZhtvi3Ont6paMn5p1p0n92/0dqZxveVfVvK0b77/kYjTfOQ7OQVkTPxZ62DfDKncpiPKvUvfdlDguADYgIUs5PLRUXZdiV4b0ULY67t2ngCkMYqpiKYc38ZhVSVQDGpHj7IEj4CvXQ2GGbU5UUenPSGoPDYytgkdOhDkHFee6y31lQjQqzgRGekGPrMB9brDo3q7bSlEMGP3notWer4Lie40C5j9R+9BazW8ue9W8m8u4atFMzj/k/xMaW0vlU3YU3DHCXahSzlilf4CveUwt2eFx7ER4vHNgD/iATI9r8vI5CHuOKz6+MxsOIc/N650w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Fib8Y8j+Fw/sN2NX69u9T+P9uNpyVHksmDfyGgxLK4M=; b=JL89hpNS3Ec2I4qZrddZiNvescyub5C9LzyGn5ydoyRZtl+M0beeRqDk1SVlpU2be4tA4A4pbtGqP9PfUoSVJ6cKijKg0sa9ZuImlB3N6AHDPCik4nxT4MdRFIeQ6zhtbAzt8tZQ9WA+UwWvpO1oaB0403gMLvqvEQ6eZdzj0nMT1HS/ff/SqtAu3XKBmWHQd4Z33e0qVyrixIGD8pmrkj14XUzr2Cha6V6qu5vJbsGA1oi+UTruFgdss4yGoVr6rZKnAB4dmy70zKSj+HciWU3uQqs/pBHhaAvx4fGwLBliWpJhOg5O71QCwa4d7xWjhGLQWEZ5ylPA/RWoy30KNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fib8Y8j+Fw/sN2NX69u9T+P9uNpyVHksmDfyGgxLK4M=; b=mv/kQ3PPxdU5sjXvX+yrcjf4l0SLV/KTpcmijD2b0J77UarRkmy4yyWxpUY9sWrAokBJYTopj1zC1W5OI0Df9IQ6FYFiWpvoGjBe4SgpMH9jfGN0rhcPcywsxYnc3kGXBbM27Mbm0hMUwEBzhegBbcA5fD7+2a4ZPxb4chA/XwU= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (52.135.97.18) by SN6PR11MB3263.namprd11.prod.outlook.com (52.135.109.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Mon, 13 Sep 2021 08:31:05 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 08:31:05 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 01/33] staging: wfx: use abbreviated message for "incorrect sequence" Date: Mon, 13 Sep 2021 10:30:13 +0200 Message-Id: <20210913083045.1881321-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> References: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 08:31:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 420088a6-8ae9-43ee-1044-08d97690d40e X-MS-TrafficTypeDiagnostic: SN6PR11MB3263: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t6p8yyxYB11XRANi3ffvpoKXGhhQW4fw3ku5I3JHabmuvrtVBsnGdDB8ivbxCWBWO4k+TJ9wARSH1+LHg4+DwzLdg6nodfSP/hzFFMF6K+npLgLbvQLLIE7oFTwtxJG4YlxckiWbWZdfqHb7VH48vUPpvZEtLCJvvTaPQuBQJrTCMla9UuMtXg3FUd/qfTcQ37bByMflM/PHVXxu+qz+oucgLAmPHR4D8bgsLuXmk/ixKv9p/YeZzaz+ZmWQ5DyRNgtxI+0M6VbHw5KgQpkQy/P5rAKkmORdx0qtkdjhXNdBQq7h7DkpfnEMMcIx7k1j+N4StQyBlPGGXp+zlCHD9drVSmYXIMtliMqNTZj2Xl9eJIwZFdOmWon8ooQZLEygXhmPxg0PMN+QlsydXDlROJW1zwmvIlJSJVNLyzBMG9kDmBqn8EkKp0VAK8nSpARFRelFn7D1lE+2ZjiLl1dADn3pxD3YmcOI+4Z8MbcuClImVDIKzojWg2LZk0xJHPZhugfh3SseRNaLjbL+SKiVE6SkjmOIFfxpTep0e9nti02/lepKk5VZV8biNovdMfESkhMhqhcSFkw7n3VlEirAfd8vK1fd3ZlQRCJ8dBSINgo0JYSV9HTOMKhR+ZVlERuiqlp+44Vohxx+wMpmB+C0fTKIZqndzyND3rg5NP7R0quF/kexp2BgBFDSL2hGOQYGBITqc5s4abw5yJ3Ac9aeow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(66574015)(107886003)(956004)(2616005)(5660300002)(54906003)(38350700002)(4326008)(6666004)(316002)(15650500001)(38100700002)(66946007)(26005)(66476007)(66556008)(186003)(8676002)(36756003)(8936002)(86362001)(508600001)(52116002)(7696005)(6486002)(1076003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?zjujH32hNn2Qpvz7ceTlhwan+i53?= =?utf-8?q?lsgEIFfgjkD/8EWQtLNRo+x4TLZzbTjSdhokEqlE1AHBc9agnqZeuAVY7PNHSPvhY?= =?utf-8?q?QRHXOCGOFGNaILC8bnkmpqQi4ESwngltRqnXZMm55cdMdzyM9yxkOntBkdWccBTE0?= =?utf-8?q?JnXMtZ1Dddulp+Du1mef1kZ5y86t4H5JZ2hecFilwaAI7odmoFRGmt9g6X2P63uQF?= =?utf-8?q?Z0sjPpwohHTz5UuQLon/JxsZ2k5P3aUjzEEpC4J7LVzdgl/uw9bD0zv4LKAt6TFmH?= =?utf-8?q?Z8jr91IgY6jeVn2afd9bwca9y2mN0dvVaE9YR1ZO7jJdf1WG6YqfCpv7QGjTNB6hQ?= =?utf-8?q?7Yg++uWWpGPJckWqa6ztESrs+HtgdzvtOqtN0UF4FTjb/PZGeAcgcpr2uPf/sYKgl?= =?utf-8?q?e4DXZoJHsHTtdk+g6NU/HQuq2AYD8lC7v1C+vWhavkcXA+niSHkLuLrkYUPUFvKuP?= =?utf-8?q?aAqqo9vv7y6CzmIOesYK9Wl9zo+ggVmpd0VIH7argldg2gBjpS4CrwYT//1URjFFe?= =?utf-8?q?pHS7dr5Ji2Srmu6XS6j4lQ2fbLKdTh7Eo9JAp5JeePRUyzuM7sISUgA63aqsOw/8h?= =?utf-8?q?WNB7EhQOIqJy05dVYLrbry1riqHatvD7L67VnWWA7UqRWi2KPSsGvfbICPuXVtSI5?= =?utf-8?q?mOMVzlvgIwOYzeVU6Ko5i/L62druwDZQJ0Oe7bPG+P03fg6DB8DMz2oKXzxpI9VgL?= =?utf-8?q?Lp2CULro5YXrB6S6WIl7zkx10FAF+3jj1yYaXU8oX3Vrmn3yC94oO75euc5OhinWm?= =?utf-8?q?SSMbhZa2NvrbuBiLG7lwtSpJHV9jPMWoPH/MHXJBV7Cv1pa07qMhbKkfz7sAcuUaU?= =?utf-8?q?aflnl4g+5YdloBC65LgBLSxmH74ODNM7OI2yXyibXYgIzhp+dVXPhp5ZdoWc4X8Xc?= =?utf-8?q?ZaAfDLlJ+YJMPMHIrxqpimTL1CnvDXCCzRaJB+RnoYYB7k+YUC/kJbGjZv4Qn8SeU?= =?utf-8?q?O18cWHNyIK5+jccOXeaV/kzdpIbXCxZcHclGtDNR6gzEmWG1NgcYnCQc+qO79sDpN?= =?utf-8?q?q2mHk2yc+gj2CrCIQsv6OZERbHd+n3fHaswL/gHN5Y9A9zxKbrT7Coxd7Egh3mtJn?= =?utf-8?q?r7rbx/AXZ9LxGLKacrBCuc00eUw354hQ7IXT6M70NH4QXvdJJ5iO3gKYvHgvo5TGK?= =?utf-8?q?wwj186z1mn/55oxDfq9DqT6AFccag58u/waUKNfLKMM7GuXnGIrg3O9WR6rQ0Gqv0?= =?utf-8?q?CdlfdGbl6BJFDqELkHxdGcP+hkemUAh6XcU2QYLb/xfqavPQE8V8ftSORsmVTkotv?= =?utf-8?q?88OOHEf8y+dn8Jdo?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 420088a6-8ae9-43ee-1044-08d97690d40e X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:31:05.5884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TxjTk537Tr12P+SuDfWHXAnUxH+03pOGTBhbok1EjO2UaZNTzM9jUoGrwxW3+WFS42cbM5Sp1KxjF5meUYTbSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3263 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The wfx driver checks carefully the coherency of of the DTIM notifications. We have noticed several times some small inconsistencies from the firmware on these notification. They have never been critical. However on the driver side they lead to big fat warnings. Worse, if these warning are displayed on UART console, they can be long to display (several hundreds of millisecs). Since, this warning is generated from a work queue, it can delay all the workqueue users. Especially, it can drastically slow down the frame management of the driver and then generate errors that are serious this time (eg. an overflow of the indication queue of the device). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index cb7e8abdf43c..a236e5bb6914 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -631,8 +631,9 @@ void wfx_suspend_resume_mc(struct wfx_vif *wvif, enum sta_notify_cmd notify_cmd) { if (notify_cmd != STA_NOTIFY_AWAKE) return; - WARN(!wfx_tx_queues_has_cab(wvif), "incorrect sequence"); - WARN(wvif->after_dtim_tx_allowed, "incorrect sequence"); + if (!wfx_tx_queues_has_cab(wvif) || wvif->after_dtim_tx_allowed) + dev_warn(wvif->wdev->dev, "incorrect sequence (%d CAB in queue)", + wfx_tx_queues_has_cab(wvif)); wvif->after_dtim_tx_allowed = true; wfx_bh_request_tx(wvif->wdev); }