| Message ID | 20210915103559.GA7060@kili (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: wwan: iosm: fix memory leak in ipc_devlink_create_region() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
> This doesn't free the first region in devlink->cd_regions[0] so it's a memory > leak. > > Fixes: 13bb8429ca98 ("net: wwan: iosm: firmware flashing and coredump > collection") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/wwan/iosm/iosm_ipc_devlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
On Wed, 15 Sep 2021 11:05:42 +0000 Kumar, M Chetan wrote: > > This doesn't free the first region in devlink->cd_regions[0] so it's a memory > > leak. > > > > Fixes: 13bb8429ca98 ("net: wwan: iosm: firmware flashing and coredump > > collection") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > --- > > drivers/net/wwan/iosm/iosm_ipc_devlink.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com> I'll toss this from patchwork because I'm going to post a revert of the entire patch. The abuse of devlink params for configuring flashing process is unacceptable.
diff --git a/drivers/net/wwan/iosm/iosm_ipc_devlink.c b/drivers/net/wwan/iosm/iosm_ipc_devlink.c index 592792c277fe..6d4f592ba0b6 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_devlink.c +++ b/drivers/net/wwan/iosm/iosm_ipc_devlink.c @@ -231,7 +231,7 @@ static int ipc_devlink_create_region(struct iosm_devlink *devlink) { struct devlink_region_ops *mdm_coredump; int rc = 0; - u8 i; + int i; mdm_coredump = devlink->iosm_devlink_mdm_coredump; for (i = 0; i < IOSM_NOF_CD_REGION; i++) { @@ -247,7 +247,7 @@ static int ipc_devlink_create_region(struct iosm_devlink *devlink) rc = PTR_ERR(devlink->cd_regions[i]); dev_err(devlink->dev, "Devlink region fail,err %d", rc); /* Delete previously created regions */ - for ( ; i > 0; i--) + for ( ; i >= 0; i--) devlink_region_destroy(devlink->cd_regions[i]); goto region_create_fail; }
This doesn't free the first region in devlink->cd_regions[0] so it's a memory leak. Fixes: 13bb8429ca98 ("net: wwan: iosm: firmware flashing and coredump collection") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/wwan/iosm/iosm_ipc_devlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)