| Message ID | 20210917120333.48074-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3503e673db234be0af57b80a03d7f5ac851e471d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] octeontx2-af: Remove redundant initialization of variable blkaddr | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 5 this patch: 5 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 17 Sep 2021 13:03:33 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable blkaddr is being initialized with a value that is never > read, it is being updated later on in a for-loop. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - [next] octeontx2-af: Remove redundant initialization of variable blkaddr https://git.kernel.org/netdev/net-next/c/3503e673db23 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c index 3bba8bc91f35..5909173ff788 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c @@ -1294,7 +1294,7 @@ int rvu_get_blkaddr_from_slot(struct rvu *rvu, int blktype, u16 pcifunc, int numlfs, total_lfs = 0, nr_blocks = 0; int i, num_blkaddr[BLK_COUNT] = { 0 }; struct rvu_block *block; - int blkaddr = -ENODEV; + int blkaddr; u16 start_slot; if (!is_blktype_attached(pfvf, blktype))