diff mbox series

ptp: ocp: add COMMON_CLK dependency

Message ID 20210920095807.1237902-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 42a99a0be307562c1bfef32bad8f89aa3c428edd
Delegated to: Netdev Maintainers
Headers show
Series ptp: ocp: add COMMON_CLK dependency | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Arnd Bergmann Sept. 20, 2021, 9:57 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Without CONFIG_COMMON_CLK, this fails to link:

arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_register_i2c':
ptp_ocp.c:(.text+0xcc0): undefined reference to `__clk_hw_register_fixed_rate'
arm-linux-gnueabi-ld: ptp_ocp.c:(.text+0xcf4): undefined reference to `devm_clk_hw_register_clkdev'
arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_detach':
ptp_ocp.c:(.text+0x1c24): undefined reference to `clk_hw_unregister_fixed_rate'

Fixes: a7e1abad13f3 ("ptp: Add clock driver for the OpenCompute TimeCard.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/ptp/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 20, 2021, 10:20 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 20 Sep 2021 11:57:49 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Without CONFIG_COMMON_CLK, this fails to link:
> 
> arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_register_i2c':
> ptp_ocp.c:(.text+0xcc0): undefined reference to `__clk_hw_register_fixed_rate'
> arm-linux-gnueabi-ld: ptp_ocp.c:(.text+0xcf4): undefined reference to `devm_clk_hw_register_clkdev'
> arm-linux-gnueabi-ld: drivers/ptp/ptp_ocp.o: in function `ptp_ocp_detach':
> ptp_ocp.c:(.text+0x1c24): undefined reference to `clk_hw_unregister_fixed_rate'
> 
> [...]

Here is the summary with links:
  - ptp: ocp: add COMMON_CLK dependency
    https://git.kernel.org/netdev/net/c/42a99a0be307

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index f02bedf41264..458218f88c5e 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -174,6 +174,7 @@  config PTP_1588_CLOCK_OCP
 	depends on I2C && MTD
 	depends on SERIAL_8250
 	depends on !S390
+	depends on COMMON_CLK
 	select NET_DEVLINK
 	help
 	  This driver adds support for an OpenCompute time card.