| Message ID | 20210923220016.18221-1-aaro.koskinen@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5ab8a447bcfee1ded709e7ff5dc7608ca9f66ae2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | smsc95xx: fix stalled rx after link change | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 24 Sep 2021 01:00:16 +0300 you wrote: > After commit 05b35e7eb9a1 ("smsc95xx: add phylib support"), link changes > are no longer propagated to usbnet. As a result, rx URB allocation won't > happen until there is a packet sent out first (this might never happen, > e.g. running just ssh server with a static IP). Fix by triggering usbnet > EVENT_LINK_CHANGE. > > Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support") > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > [...] Here is the summary with links: - smsc95xx: fix stalled rx after link change https://git.kernel.org/netdev/net/c/5ab8a447bcfe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 7d953974eb9b..26b1bd8e845b 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1178,7 +1178,10 @@ static void smsc95xx_unbind(struct usbnet *dev, struct usb_interface *intf) static void smsc95xx_handle_link_change(struct net_device *net) { + struct usbnet *dev = netdev_priv(net); + phy_print_status(net->phydev); + usbnet_defer_kevent(dev, EVENT_LINK_CHANGE); } static int smsc95xx_start_phy(struct usbnet *dev)
After commit 05b35e7eb9a1 ("smsc95xx: add phylib support"), link changes are no longer propagated to usbnet. As a result, rx URB allocation won't happen until there is a packet sent out first (this might never happen, e.g. running just ssh server with a static IP). Fix by triggering usbnet EVENT_LINK_CHANGE. Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support") Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> --- drivers/net/usb/smsc95xx.c | 3 +++ 1 file changed, 3 insertions(+)