diff mbox series

[-next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c

Message ID 20210928164011.1454-1-liumh1@shanghaitech.edu.cn (mailing list archive)
State Accepted
Delegated to: Netdev Maintainers
Headers show
Series [-next] net/ipv4/fib_notifier.c remove superfluous header files from fib_notifier.c | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/header_inline success Link

Commit Message

Mianhan Liu Sept. 28, 2021, 4:40 p.m. UTC
fib_notifier.chasn't use any macro or function declared in net/netns/ipv4.h.
Thus, these files can be removed from fib_notifier.c safely without
affecting the compilation of the net/ipv4 module.

Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>

---
 net/ipv4/fib_notifier.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jakub Kicinski Sept. 29, 2021, 12:34 a.m. UTC | #1
On Wed, 29 Sep 2021 00:40:11 +0800 Mianhan Liu wrote:
> fib_notifier.chasn't use any macro or function declared in net/netns/ipv4.h.
> Thus, these files can be removed from fib_notifier.c safely without
> affecting the compilation of the net/ipv4 module.
> 
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>

This one looks fine, applied, thanks!
diff mbox series

Patch

diff --git a/net/ipv4/fib_notifier.c b/net/ipv4/fib_notifier.c
index 0c28bd469..0e23ade74 100644
--- a/net/ipv4/fib_notifier.c
+++ b/net/ipv4/fib_notifier.c
@@ -6,7 +6,6 @@ 
 #include <linux/export.h>
 #include <net/net_namespace.h>
 #include <net/fib_notifier.h>
-#include <net/netns/ipv4.h>
 #include <net/ip_fib.h>
 
 int call_fib4_notifier(struct notifier_block *nb,