| Message ID | 20210928174943.8148-1-liumh1@shanghaitech.edu.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] net/ipv4/datagram.c: remove superfluous header files from datagram.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
On Wed, 29 Sep 2021 01:49:43 +0800 Mianhan Liu wrote: > datagram.c hasn't use any macro or function declared in linux/ip.h, > and linux/module.h. > Thus, these files can be removed from datagram.c safely without > affecting the compilation of the net/ipv4 module > > Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn> > > --- > net/ipv4/datagram.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c > index 4a8550c49..2dc5f1890 100644 > --- a/net/ipv4/datagram.c > +++ b/net/ipv4/datagram.c > @@ -8,8 +8,6 @@ > */ > > #include <linux/types.h> > -#include <linux/module.h> If we remove this one we need to add an include for linux/export.h > -#include <linux/ip.h> This indeed looks unnecessary. > #include <linux/in.h> > #include <net/ip.h> > #include <net/sock.h>
diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c index 4a8550c49..2dc5f1890 100644 --- a/net/ipv4/datagram.c +++ b/net/ipv4/datagram.c @@ -8,8 +8,6 @@ */ #include <linux/types.h> -#include <linux/module.h> -#include <linux/ip.h> #include <linux/in.h> #include <net/ip.h> #include <net/sock.h>
datagram.c hasn't use any macro or function declared in linux/ip.h, and linux/module.h. Thus, these files can be removed from datagram.c safely without affecting the compilation of the net/ipv4 module Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn> --- net/ipv4/datagram.c | 2 -- 1 file changed, 2 deletions(-)