diff mbox series

[v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario

Message ID 20211007155238.4487-1-pkushwaha@marvell.com (mailing list archive)
State Accepted
Commit e761523d0b407518d4812ada39957bd11227e95b
Delegated to: Netdev Maintainers
Headers show
Series [v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario | expand

Checks

Context Check Description
netdev/cover_letter success Single patches do not need cover letters
netdev/fixes_present success Fixes tag not required for -next series
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers warning 1 maintainers not CCed: GR-everest-linux-l2@marvell.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Fixes tag looks correct
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 18 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/header_inline success No static functions without inline keyword in header files

Commit Message

Prabhakar Kushwaha Oct. 7, 2021, 3:52 p.m. UTC
This patch fixes below compliation error in case CONFIG_QED_SRIOV not
defined.
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
‘qed_fw_err_handler’:
drivers/net/ethernet/qlogic/qed/qed_dev.c:2390:3: error: implicit
declaration of function ‘qed_sriov_vfpf_malicious’; did you mean
‘qed_iov_vf_task’? [-Werror=implicit-function-declaration]
   qed_sriov_vfpf_malicious(p_hwfn, &data->err_data);
   ^~~~~~~~~~~~~~~~~~~~~~~~
   qed_iov_vf_task
drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
‘qed_common_eqe_event’:
drivers/net/ethernet/qlogic/qed/qed_dev.c:2410:10: error: implicit
declaration of function ‘qed_sriov_eqe_event’; did you mean
‘qed_common_eqe_event’? [-Werror=implicit-function-declaration]
   return qed_sriov_eqe_event(p_hwfn, opcode, echo, data,
          ^~~~~~~~~~~~~~~~~~~
          qed_common_eqe_event

Fixes: fe40a830dcde ("qed: Update qed_hsi.h for fw 8.59.1.0")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
Signed-off-by: Omkar Kulkarni <okulkarni@marvell.com>
Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
---
This patch is targeted for the repo
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git

Changes for v2:
  - Fixed patchwork's netdev/verify_fixes "error".


 drivers/net/ethernet/qlogic/qed/qed_sriov.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 8, 2021, 4:30 p.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 7 Oct 2021 18:52:38 +0300 you wrote:
> This patch fixes below compliation error in case CONFIG_QED_SRIOV not
> defined.
> drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
> ‘qed_fw_err_handler’:
> drivers/net/ethernet/qlogic/qed/qed_dev.c:2390:3: error: implicit
> declaration of function ‘qed_sriov_vfpf_malicious’; did you mean
> ‘qed_iov_vf_task’? [-Werror=implicit-function-declaration]
>    qed_sriov_vfpf_malicious(p_hwfn, &data->err_data);
>    ^~~~~~~~~~~~~~~~~~~~~~~~
>    qed_iov_vf_task
> drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
> ‘qed_common_eqe_event’:
> drivers/net/ethernet/qlogic/qed/qed_dev.c:2410:10: error: implicit
> declaration of function ‘qed_sriov_eqe_event’; did you mean
> ‘qed_common_eqe_event’? [-Werror=implicit-function-declaration]
>    return qed_sriov_eqe_event(p_hwfn, opcode, echo, data,
>           ^~~~~~~~~~~~~~~~~~~
>           qed_common_eqe_event
> 
> [...]

Here is the summary with links:
  - [v2] qed: Fix compilation for CONFIG_QED_SRIOV undefined scenario
    https://git.kernel.org/netdev/net-next/c/e761523d0b40

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.h b/drivers/net/ethernet/qlogic/qed/qed_sriov.h
index 1edf9c44dc67..f448e3dd6c8b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.h
@@ -478,6 +478,18 @@  static inline int qed_sriov_disable(struct qed_dev *cdev, bool pci_enabled)
 static inline void qed_inform_vf_link_state(struct qed_hwfn *hwfn)
 {
 }
+
+static inline void qed_sriov_vfpf_malicious(struct qed_hwfn *p_hwfn,
+					    struct fw_err_data *p_data)
+{
+}
+
+static inline int qed_sriov_eqe_event(struct qed_hwfn *p_hwfn, u8 opcode,
+				      __le16 echo, union event_ring_data *data,
+				      u8  fw_return_code)
+{
+	return 0;
+}
 #endif
 
 #define qed_for_each_vf(_p_hwfn, _i)			  \