| Message ID | 20211008002225.2426-16-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Multiple improvement for qca8337 switch | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Series has a cover letter |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
On Fri, Oct 08, 2021 at 02:22:25AM +0200, Ansuel Smith wrote: > QCA8328 is the birrget brother of 8327. Document the new compatible birrget? > binding. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index 9fb4db65907e..0e84500b8db2 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -3,6 +3,7 @@ > Required properties: > > - compatible: should be one of: > + "qca,qca8328" > "qca,qca8327" > "qca,qca8334" > "qca,qca8337" This is much nice than the old DT property. But since the internal IDs are the same, i think it would be good to add a little documentation here about how the 8327 and 8328 differ, since most people are not going to look at the commit message. Andrew
On Sat, Oct 09, 2021 at 07:24:45PM +0200, Andrew Lunn wrote: > On Fri, Oct 08, 2021 at 02:22:25AM +0200, Ansuel Smith wrote: > > QCA8328 is the birrget brother of 8327. Document the new compatible > > birrget? > > > Me sending patch lat at night... it was brother. > > binding. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > index 9fb4db65907e..0e84500b8db2 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > @@ -3,6 +3,7 @@ > > Required properties: > > > > - compatible: should be one of: > > + "qca,qca8328" > > "qca,qca8327" > > "qca,qca8334" > > "qca,qca8337" > > This is much nice than the old DT property. But since the internal IDs > are the same, i think it would be good to add a little documentation > here about how the 8327 and 8328 differ, since most people are not > going to look at the commit message. > > Andrew Ok will add some description on how to understand the correct compatible to use.
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt index 9fb4db65907e..0e84500b8db2 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt @@ -3,6 +3,7 @@ Required properties: - compatible: should be one of: + "qca,qca8328" "qca,qca8327" "qca,qca8334" "qca,qca8337"
QCA8328 is the birrget brother of 8327. Document the new compatible binding. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 1 + 1 file changed, 1 insertion(+)