| Message ID | 20211012023231.19911-1-wanjiabing@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | BPF |
| Headers | show |
| Series | [v2] selftests: bpf: Remove duplicated include in cgroup_helpers | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
| bpf/vmtest-bpf | fail | VM_Test |
| bpf/vmtest-bpf-PR | fail | PR summary |
| bpf/vmtest-bpf-next-PR | success | PR summary |
| bpf/vmtest-bpf-next | success | VM_Test |
Wan Jiabing wrote: > Fix following checkincludes.pl warning: > ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c > tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more > than once. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > Changelog: > v2: > - Fix the commit description. > --- The Subject is a bit unusual. Typically it would be something like, "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers" For the actual patch though LGTM. Acked-by: John Fastabend <john.fastabend@gmail.com>
On Mon, Oct 18, 2021 at 9:07 AM John Fastabend <john.fastabend@gmail.com> wrote: > > Wan Jiabing wrote: > > Fix following checkincludes.pl warning: > > ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c > > tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more > > than once. > > > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > > --- > > Changelog: > > v2: > > - Fix the commit description. > > --- > > The Subject is a bit unusual. Typically it would be something like, > > "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers" Also for selftests we use "selftests/bpf: " prefix (at least we generally try, for consistency). Fixed up, applied to bpf-next. Thanks. > > For the actual patch though LGTM. > > Acked-by: John Fastabend <john.fastabend@gmail.com>
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c index 8fcd44841bb2..9d59c3990ca8 100644 --- a/tools/testing/selftests/bpf/cgroup_helpers.c +++ b/tools/testing/selftests/bpf/cgroup_helpers.c @@ -11,7 +11,6 @@ #include <fcntl.h> #include <unistd.h> #include <ftw.h> -#include <unistd.h> #include "cgroup_helpers.h"
Fix following checkincludes.pl warning: ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more than once. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- Changelog: v2: - Fix the commit description. --- tools/testing/selftests/bpf/cgroup_helpers.c | 1 - 1 file changed, 1 deletion(-)